Mi/feature/merge #1153
Mi/feature/merge #1153
Conversation
sesheta
added
the
size/XS
| @@ -1526,6 +1527,7 @@ def schedule_mi_workflow( | |||
| "ENTITIES": entities, | |||
| "KNOWLEDGE_PATH": knowledge_path, | |||
| "MI_THOTH": "1" if mi_used_for_thoth else "0", | |||
| "MI_MERGE": "1" if mi_merge else "0", | |||
There was a problem hiding this comment.
Hint: booleans are ints in python: str(int(mi_merge))
There was a problem hiding this comment.
I know, I was just following other declarations in this file as well, see
common/thoth/common/openshift.py
Line 1368 in 5b96cd3
Can I then refactor these as e.g. "MI_MERGE": mi_merge ?
There was a problem hiding this comment.
Hint: booleans are ints in python:
str(int(mi_merge))
ooh I get it now, you mean it's better to use casting than the ternary operator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fridex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
Related Issues and Dependencies
Related to thoth-station/mi#364
This introduces a breaking change
This Pull Request implements
… Explain your changes.
Description