-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not process entries from poetry.lock until their category is known #299
Conversation
Now is the time to check the failures and see whether the code is wrong or the test is wrong. |
six should be in dev because it's dependency of requests-mock
greenlet transitive dep of alembic
werkzeug is a dependency of flask
There are two kind of breaking changes now:
|
It seems that the new test with complex dependencies is not compatible with Python <= 3.7. Fixed. |
Does anybody have a plan to do a review? |
I had a brief look on changes - it looks like they are well covered by tests. Unfortunately, I don't have time for an in-depth review. Feel free to consider +1 from me. Very nice job and thanks for looking into this! 👍🏻 💯 It would be great if @yrro could verify this patchset on the originally reported issue or provide the related lockfile (if not done already). |
I think my pyproject.toml and lockfile made it into the tests for this PR. But I hope I can give it a manual test on my proejct some time this week. |
Thank you both. Sam is correct - his configuration is now part of the tests. |
Or we can test it out there in the wild with a new release 🤔 |
All right, let's give it a try. |
Related Issues and Dependencies
#295
Let's see what this change will break. I expect possible incompatibility with older poetry.