-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify users about Python packaged in F35 as RPMs #21342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks! 💯
Just to double-check these files pass schema validation, could you try running thoth-adviser:
./thoth-adviser validate-prescriptions ../prescriptions/prescriptions
prescriptions/2p_/2ping/f35_rpm.yaml
Outdated
@@ -0,0 +1,16 @@ | |||
units: | |||
wraps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation looks off here. Please try running pre-commit to verify YAML files are correct.
prescriptions/2p_/2ping/f35_rpm.yaml
Outdated
- name: 2pingFedora35RPMWrap | ||
type: wrap | ||
should_include: | ||
adviser_pipeline: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please include the operating system here? That way, we show this information only for matching environments:
runtime_environments:
operating_systems:
- name: fedora
version: "35"
a47583a
to
f42c17e
Compare
When I ran this for the entire prescriptions directory it threw an error on file
But when testing one of the f35_rpm.yaml files which were programatically generated it succeeds:
|
f42c17e
to
9a8ae4a
Compare
pre-commit passes locally, ready for review. |
bump @fridex |
Perfect, thanks a lot! 👍🏻 /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fridex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related Issues and Dependencies
Addresses: thoth-station/s2i-thoth#231 (comment)
Related to: thoth-station/adviser#1961
- Code is based off of adviser 1961 but since our repository structure has been changed changes were needed. Additionally because the
dnf repoquery
s take a long time on a PC (2-3 hours), I will rework this into a Job which can be run on a cluster. Issue will be posted inthoth-station/misc
for this.Similar to: https://github.com/thoth-station/prescriptions/pull/42/files but for
f35
instead ofubi8
This introduces a breaking change
This should yield a new module release
This Pull Request implements
Adding
f35
Python packages as rpms./cc @fridex