Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify users about Python packaged in F35 as RPMs #21342

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

Gregory-Pereira
Copy link
Member

Related Issues and Dependencies

Addresses: thoth-station/s2i-thoth#231 (comment)
Related to: thoth-station/adviser#1961
- Code is based off of adviser 1961 but since our repository structure has been changed changes were needed. Additionally because the dnf repoquerys take a long time on a PC (2-3 hours), I will rework this into a Job which can be run on a cluster. Issue will be posted in thoth-station/misc for this.
Similar to: https://github.com/thoth-station/prescriptions/pull/42/files but for f35 instead of ubi8

This introduces a breaking change

  • No breaking changes were introduced

This should yield a new module release

  • I am not certain but I don't think so.

This Pull Request implements

Adding f35 Python packages as rpms.

/cc @fridex

@sesheta sesheta requested a review from fridex March 31, 2022 23:42
@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 31, 2022
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! 💯

Just to double-check these files pass schema validation, could you try running thoth-adviser:

./thoth-adviser validate-prescriptions ../prescriptions/prescriptions

@@ -0,0 +1,16 @@
units:
wraps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation looks off here. Please try running pre-commit to verify YAML files are correct.

- name: 2pingFedora35RPMWrap
type: wrap
should_include:
adviser_pipeline: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include the operating system here? That way, we show this information only for matching environments:

      runtime_environments:
        operating_systems:
        - name: fedora
          version: "35"

@Gregory-Pereira
Copy link
Member Author

When I ran this for the entire prescriptions directory it threw an error on file prescriptions/_containers/quay_security.yaml.

./thoth-adviser validate-prescriptions ../prescriptions/prescriptions
2022-04-01 17:05:56,693 98140 WARNING  thoth.common:344: Logging to a Sentry instance is turned off
2022-04-01 17:05:56,693 98140 INFO     thoth.common:366: Logging to rsyslog endpoint is turned off
2022-04-01 17:05:56,695 98140 INFO     thoth.adviser:248: Version: 0.47.0
2022-04-01 17:05:56,695 98140 INFO     thoth.adviser:973: Validating prescriptions in '../prescriptions/prescriptions'
2022-04-01 17:05:56,696 98140 INFO     thoth.adviser.prescription.v1.prescription:330: Using prescriptions 'thoth' release 'dev+git'
2022-04-01 17:05:56,716 98140 ERROR    thoth.adviser.prescription.v1.prescription:195: Failed to validate schema for prescription: extra keys not allowed @ data['units']['boots'][0]['metadata']
 ERROR    thoth.adviser.prescription.v1.prescription:298: Failed to load prescription from '../prescriptions/prescriptions/_containers/quay_security.yaml'

But when testing one of the f35_rpm.yaml files which were programatically generated it succeeds:

$ ./thoth-adviser validate-prescriptions ../prescriptions/prescriptions/py_/pyvo/f35_rpm.yaml
WARNING  thoth.common:344: Logging to a Sentry instance is turned off
2022-04-01 17:07:04,792 98190 INFO     thoth.common:366: Logging to rsyslog endpoint is turned off
2022-04-01 17:07:04,793 98190 INFO     thoth.adviser:248: Version: 0.47.0
2022-04-01 17:07:04,793 98190 INFO     thoth.adviser:973: Validating prescriptions in '../prescriptions/prescriptions/py_/pyvo/f35_rpm.yaml'
2022-04-01 17:07:04,794 98190 INFO     thoth.adviser:975: Prescriptions '../prescriptions/prescriptions/py_/pyvo/f35_rpm.yaml' validated successfully
count:
  boots_count: 0
  pseudonyms_count: 0
  sieves_count: 0
  steps_count: 0
  strides_count: 0
  wraps_count: 1
count_all: 1
prescriptions:
- name: UNKNOWN
  release: UNKNOWN

@Gregory-Pereira
Copy link
Member Author

pre-commit passes locally, ready for review.

@Gregory-Pereira
Copy link
Member Author

bump @fridex

@fridex
Copy link
Contributor

fridex commented Apr 22, 2022

Perfect, thanks a lot! 👍🏻

/approve

@sesheta
Copy link
Member

sesheta commented Apr 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2022
@sesheta sesheta merged commit 57a7846 into thoth-station:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants