Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keb-update step to base template #2191

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

KPostOffice
Copy link
Member

Related Issues and Dependencies

Fixes: #2165

Does this require new deployment ?

  • Deployment for Test and Stage AICoE/aicoe-cd and Prod operate-first/argocd-apps.

Description

Keb installation table was not being updated because the step was missing from the base workflow

@sesheta sesheta requested review from fridex and goern December 14, 2021 22:22
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 14, 2021
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
one minor change is needed

kebechet/overlays/test/kebechet.yaml Show resolved Hide resolved
@harshad16
Copy link
Member

/approve
merging to fix the test env.
thanks

@harshad16 harshad16 merged commit 262b135 into thoth-station:master Dec 16, 2021
@sesheta sesheta added this to the 2021.12.20 milestone Dec 16, 2021
@sesheta
Copy link
Member

sesheta commented Dec 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@sesheta
Copy link
Member

sesheta commented Dec 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KPostOffice KPostOffice deleted the add_keb_update2prod branch June 8, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kebechet github installation table managers columns are all false
3 participants