Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Commit

Permalink
extends plese and proto fixes to prs that were inflight when these fi…
Browse files Browse the repository at this point in the history
…xes landed (#33)
  • Loading branch information
northdpole authored May 29, 2020
1 parent 47589a7 commit 3149e38
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 14 deletions.
6 changes: 3 additions & 3 deletions consumers/slack/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
subinclude("@pleasings//docker")
subinclude("@third_party/subrepos/pleasings//docker")


go_binary(
Expand All @@ -9,8 +9,8 @@ go_binary(
deps = [
"//consumers",
"//consumers/slack/utils:utils",
"//pkg/genproto/v1",
"//third_party/go:golang_protobuf",
"//api/proto:v1",
"//third_party/go:protobuf",
],
)

Expand Down
2 changes: 1 addition & 1 deletion consumers/slack/types/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ go_library(
visibility = [
"//consumers/slack/...",
],
deps = ["//pkg/genproto/v1",]
deps = ["//api/proto:v1",]

)
2 changes: 1 addition & 1 deletion consumers/slack/types/full-document.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package types
import (
"time"

v1 "github.com/thought-machine/dracon/pkg/genproto/v1"
v1 "api/proto/v1"
)

type FullDocument struct {
Expand Down
9 changes: 5 additions & 4 deletions consumers/slack/utils/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ go_library(
visibility = [
"//consumers/slack/...",
],
deps = ["//pkg/genproto/v1",
deps = ["//api/proto:v1",
"//consumers/slack/types",
"//third_party/go:golang_protobuf",]
"//third_party/go:protobuf",
]

)
go_test(
Expand All @@ -21,9 +22,9 @@ go_test(
deps = [
":utils",
"//consumers",
"//pkg/genproto/v1",
"//api/proto:v1",
"//third_party/go:gogo_protobuf",
"//third_party/go:golang_protobuf",
"//third_party/go:protobuf",
"//third_party/go:stretchr_testify",
],
)
2 changes: 1 addition & 1 deletion consumers/slack/utils/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"time"

"github.com/golang/protobuf/ptypes"
v1 "github.com/thought-machine/dracon/pkg/genproto/v1"
"api/proto/v1"
)

func push(b string, webhook string) error {
Expand Down
2 changes: 1 addition & 1 deletion consumers/slack/utils/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (

"github.com/golang/protobuf/ptypes"
"github.com/stretchr/testify/assert"
v1 "github.com/thought-machine/dracon/pkg/genproto/v1"
"api/proto/v1"
)

//TODO tests: count* get*
Expand Down
2 changes: 1 addition & 1 deletion producers/dependency_check/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
subinclude("@pleasings//docker")
subinclude("@third_party/subrepos/pleasings//docker")

go_binary(
name = "dependency_check",
Expand Down
2 changes: 1 addition & 1 deletion producers/pipsafety/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
subinclude("@pleasings//docker")
subinclude("@third_party/subrepos/pleasings//docker")

go_binary(
name = "pipsafety",
Expand Down
2 changes: 1 addition & 1 deletion producers/pipsafety/types/safety-issue.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ func (i *SafetyIssue) UnmarshalJSON(data []byte) error {
i.Name, _ = v[0].(string)
i.VersionConstraint, _ = v[1].(string)
i.CurrentVersion, _ = v[2].(string)
i.Descriptionm, _ = v[3].(string)
i.Description, _ = v[3].(string)
return nil
}

0 comments on commit 3149e38

Please sign in to comment.