-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show GitHub projects on new About tab, add Home screen content #53
Conversation
3c446fa
to
7a573e2
Compare
|
||
# now run without the dry-run flag: | ||
> rsync -avp . ../../templates/boilerplate/ --exclude node_modules --exclude .cache --exclude .expo --exclude .vscode --exclude assets --exclude .git --exclude .gitignore | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of automating this process as part of a command? Are there parts of the rsync process that would be reliant on the specifics of each new feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! I added a script bin/sync-from-app.js
which syncs files back from the app into Belt, and I updated the CONTRIBUTING.md doc.
@@ -30,6 +30,7 @@ | |||
"msw": "^2.2.14", | |||
"react": "18.2.0", | |||
"react-native": "0.74.5", | |||
"react-native-keyboard-aware-scroll-view": "^0.9.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are adding react-native-keyboard-aware-scroll-view
do we still need the existing react-native-keyboard-aware-scrollview
? (scroll-view
vs scrollview
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! scroll-view is actually what we want. It must have been a mistake to originally add scrollview. I removed scrollview
.
2f2a3bc
to
d5c7447
Compare
d5c7447
to
4d501b5
Compare
I chatted with Diego at the end of his day. Since his blog post announcing Belt will go out tomorrow, I will go ahead and merge this and cut a build, so we have these updates in place. |
demo.mov
Note: this loads projects from an app hosted on my Vercel account. Todo, move to thoughtbot-owned.