Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue where the
assets
images were all corrupted in the generated Belt app. This is occurring because Belt reads files as utf-8 text and then writes them when copying. It isn't handling binary files appropriately. The only binary files I’m aware of right now are intemplates/boilerplate/assets
.To reproduce the original issue, from Belt project dir:
This updates the
copyTemplateDirectory
function to usefs.copy
for binary files (currently defined using an array of filenames that we identify as binary, but we might want something more robust in the future) instead of reading the file, optionally transforming it, and then writing it.