Support Rails 8 authentication generator

[jeromedalbert]

Follow-up to rspec/rspec-rails#2811.

Problem

When running bin/rails generate authentication for a Rails 8 app that has the rspec-rails gem, generation ends with the following error: error factory_bot [not found].

This is because rspec-rails' AuthenticationGenerator contains hook_for :fixture_replacement, which calls factory_bot_rails, but it errors out since factory_bot_rails does not have an authentication generator.

Solution

Add authentication generator that creates a user factory with the email_address and password_digest fields. These fields come from the Rails authentication generator.

[jeromedalbert]

rspec/rspec-rails#2811 was merged so this PR is ready for review.

[brentdodell]

Thanks for your work on this (and rspec-rails) @jeromedalbert! I ran into these issues while spinning up a new Rails 8 app.

Do we know what’s preventing it from being merged? I see one approval, but @neilvcarvalho, I see you added yourself as a reviewer recently.

Thanks!

[neilvcarvalho]

Hi @brentdodell and @jeromedalbert! I'm going to review this PR (and other Rails 8 related work) this Friday, and possibly create a new release already.

[brentdodell]

I don't think test/factories/users.rb should be static here. It doesn't allow overriding things like the factory_bot directory, suffix, etc.

I think you'll need to include options, and build up the name dynamically.

[neilvcarvalho]

Another thing that the model generator does is checking if you already have a factory file, such as a global factories.rb instead of a factories directory. If you do, it appends the factory block to this file, instead of creating a new file.

[neilvcarvalho]

Besides the comments made by @brentdodell and me, could you also add tests? We currently have a Cucumber feature test for that on features/generators.feature

[neilvcarvalho]

Another thing that the model generator does is checking if you already have a factory file, such as a global factories.rb instead of a factories directory. If you do, it appends the factory block to this file, instead of creating a new file.

[jeromedalbert]

could you also add tests? We currently have a Cucumber feature test for that on features/generators.feature

@neilvcarvalho rspec-rails does not currently have a released version containing the Rails 8 authentication generator; it's been on their main branch for now, as I suspect @JonRowe will prepare a separate release for Rails 8 support at some point. In the meantime, in order to add cucumber tests for the Rails 8 rspec-rails generator, I required rspec-rails as a git source in my test.

However the new test fails on my local. The error I get seems to be The git source https://github.com/rspec/rspec-rails.git is not yet checked out. Please run bundle install before trying to start your application (Bundler::GitError). I am not familiar with Cucumber so I may have missed something. I have pushed my work in progress test in this PR, so if someone else wants to have a look, throw ideas, or add to this PR, it's all good.

EDIT: It looks like feature specs are passing in CI, so I guess it's only an issue on my local.