add static_page rails generator #321
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| end | ||
|
|
||
| it "creates an HTML.ERB page template in the correct location" do | ||
| expect(File.exist?("#{destination}/app/views/pages/#{filename}.html.erb")).to be(true) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [90/80]
|
|
||
| before do | ||
| FileUtils.mkdir_p(destination) | ||
| Rails::Generators.invoke('static_page', [filename], destination_root: destination) |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Metrics/LineLength: Line is too long. [86/80]
| RSpec.describe StaticPageGenerator, type: :generator do | ||
| # Define the destination directory for generator output | ||
| let(:destination) { Rails.root.join('tmp/generators') } | ||
| let(:filename) { 'homepage' } |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
|
||
| RSpec.describe StaticPageGenerator, type: :generator do | ||
| # Define the destination directory for generator output | ||
| let(:destination) { Rails.root.join('tmp/generators') } |
There was a problem hiding this comment.
Rails/FilePath: Please use Rails.root.join('path', 'to') instead.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -0,0 +1,22 @@ | |||
| require 'spec_helper' | |||
| require 'rails/generators' | |||
| require_relative '../../lib/generators/static_page_generator.rb' # Make sure this path is correct for your project | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Metrics/LineLength: Line is too long. [114/80]
| @@ -0,0 +1,22 @@ | |||
| require 'spec_helper' | |||
| require 'rails/generators' | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -0,0 +1,22 @@ | |||
| require 'spec_helper' | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Not sure if these hound critiques are valid as I largely tried following convention within the project |
|
failed to see new features weren't being added :( |
whatnotery
changed the title
|
Hi @whatnotery thank you for contribution but this library is in maintenance mode, which means we will only accept bug fixes/dependencies updates contributions. We have other gems you can contribute to, if you're interested. This post shares some active ones. Thank you! |
This PR creates the generator requested in #303
Hope this is helpful!