Fixes for breaking changes in Rails 8 #1631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed in Rails 8.0, see rails/rails@8069cc8
Propshaft is default from Rails 8. See rails/rails#51799
|
I realize now that some of these issues will already happen at Rails 7.2 - I'll have to rebase and amend my commits accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running tests against Rails main branch for one of my projects and noticed there are a couple things breaking in shoulda-matchers. Most of the things (so far) are resolved in this PR, and I've submitted a fix to Rails that solves a regression indicated by the shoulda-matcher test suite (see rails/rails#51929).
Let me know if you'd like me to refactor and/or reword anything here.
I also think it would make sense to add tests against the main branch/Rails 8, but I'm unable to get the acceptance specs to play along nicely and I don't want to commit the appraisal I have for the unit specs
as it depends on our fork of Rails to fully passuntil the current changes are reviewed and I've figured out how to get the acceptance specs to run.