Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to github workflows #41

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Move to github workflows #41

merged 1 commit into from
Apr 16, 2024

Conversation

jho406
Copy link
Collaborator

@jho406 jho406 commented Apr 13, 2024

Move to github workflows

This commit moves CI from circle to gh workflow. We also add a test for rails
main that is currently failing. I think its a binstub issue, and I'll look into this
later, but merging this anyway still seems valuable.

@jho406 jho406 force-pushed the move-away-from-circleci branch 3 times, most recently from 2a23a7a to a8a901e Compare April 15, 2024 04:18
@jho406 jho406 changed the title wip Move to github workflows Apr 15, 2024
@jho406 jho406 requested a review from whitecl April 15, 2024 04:19
This commit moves CI from circle to gh workflow. We also add a test for rails
main that is currently failing. I think its a binstub issue, and I'll look into this
later, but merging this anyway still seems valuable.
Copy link
Contributor

@whitecl whitecl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I assume failing on Rails/main is not a blocker here and something to investigate afterwards.

@jho406 jho406 merged commit 87caca2 into main Apr 16, 2024
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants