Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Generator: Improvements #1168

Merged

Commits on Mar 21, 2024

  1. Testing Generator: Improvements

    Follow-up to #1156
    
    Creates parity with Rails' decision to [use a headless driver by
    default][headless].
    
    This will be fixed in an [upcoming release][rspec] of rspec-rails, but I
    felt it was important to capture here. Additionally, it ensures the
    `screen_size` is the same as what is set in Rails.
    
    Removes `webdrivers` dependency in favor of `selenium-webdriver`. This
    generator assumes the app was generated with the `--skip-test` flag,
    which means we need to add the `selenium-webdriver` and `capybara` gems.
    
    Updates `action_dispatch-testing-integration-capybara` dependency to the
    most recent tagged release in an effort to suppress Dependabot
    notifications.
    
    Ensure all files under `spec/support` are loaded by uncommenting a line
    generated by the RSpec installation script.
    
    [headless]: rails/rails#50512
    [rspec]: rspec/rspec-rails#2746
    stevepolitodesign committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    6c3ad48 View commit details
    Browse the repository at this point in the history