Test Cleanup: Improve test setup #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevepolitodesign
force-pushed
the
suspenders-3-0-0-refactor-tests
branch
from
f278250
to
626d856
Compare
Use `touch` test helper instead of directly working with the `File` class during the setup phase. Also create [file_fixtures][] to simplify test setup. Because the newly added file fixtures are processed with standard, I needed to adjust the testing generator to account for a minor violation. [file_fixtures]: https://api.rubyonrails.org/classes/ActiveSupport/Testing/FileFixtures.html#method-i-file_fixture
stevepolitodesign
force-pushed
the
suspenders-3-0-0-refactor-tests
branch
from
626d856
to
e53a42b
Compare
stevepolitodesign
added a commit
that referenced
this pull request
Apr 13, 2024
Use `with_test_suite` helper to clean up existing test setup. Also cleans up test setup by using a `file_fixture` that was missed in #1183
stevepolitodesign
added a commit
that referenced
this pull request
May 10, 2024
Use `touch` test helper instead of directly working with the `File` class during the setup phase. Also create [file_fixtures][] to simplify test setup. Because the newly added file fixtures are processed with standard, I needed to adjust the testing generator to account for a minor violation. [file_fixtures]: https://api.rubyonrails.org/classes/ActiveSupport/Testing/FileFixtures.html#method-i-file_fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
touchtest helper instead of directly working with theFileclass during the setup phase.Also create file_fixtures to simplify test setup.
Because the newly added file fixtures are processed with standard, I needed to adjust the testing generator to account for a minor violation.