Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify a tag when installing capybara_accessible_selectors #1227

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Specify a tag when installing capybara_accessible_selectors #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9740ba6
Specify a tag when installing capybara_accessible_selectors based on …
louis-antonopoulos Oct 8, 2024
9a45eb2
Update NEWS.md
louis-antonopoulos Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
Unreleased

* Require `--skip-rubocop` in favor of our [linting configuration][]
* Fixed: [Specify a tag when installing capybara_accessible_selectors](https://github.com/thoughtbot/suspenders/issues/1228)

[linting configuration]: https://github.com/thoughtbot/suspenders/blob/main/FEATURES.md#linting

Expand Down
2 changes: 1 addition & 1 deletion lib/generators/suspenders/accessibility_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class AccessibilityGenerator < Rails::Generators::Base
def add_capybara_gems
gem_group :test do
gem "capybara_accessibility_audit", github: "thoughtbot/capybara_accessibility_audit"
gem "capybara_accessible_selectors", github: "citizensadvice/capybara_accessible_selectors"
gem "capybara_accessible_selectors", github: "citizensadvice/capybara_accessible_selectors", tag: "v0.12.0"
end
Bundler.with_unbundled_env { run "bundle install" }
end
Expand Down
2 changes: 1 addition & 1 deletion test/generators/suspenders/accessibility_generator_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class AccessibilityGeneratorTest < Rails::Generators::TestCase
expected_output = <<~RUBY
group :test do
gem "capybara_accessibility_audit", github: "thoughtbot/capybara_accessibility_audit"
gem "capybara_accessible_selectors", github: "citizensadvice/capybara_accessible_selectors"
gem "capybara_accessible_selectors", github: "citizensadvice/capybara_accessible_selectors", tag: "v0.12.0"
end
RUBY

Expand Down