Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow running against suspenders main #1230

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Allow running against suspenders main #1230

merged 6 commits into from
Oct 8, 2024

Conversation

louis-antonopoulos
Copy link
Contributor

@louis-antonopoulos louis-antonopoulos commented Oct 8, 2024 •
edited
Loading

This PR:

Example:

rails new app_name \
 --suspenders-main \
 --skip-rubocop \
 --skip-test \
 -d=postgresql \
 -m=https://raw.githubusercontent.com/thoughtbot/suspenders/main/lib/install/web.rb

Co-authored-by: Steve Polito [email protected]

louis-antonopoulos and others added 4 commits October 8, 2024 17:25
@louis-antonopoulos @stevepolitodesign
Update markdown in web_generator.rb
2a13a8a 
Add --suspenders_main parameter example

Use double \ for line breaks

Co-authored-by: Steve Polito <[email protected]>
@louis-antonopoulos
Condense suspenders_main block
b3e2c18
@louis-antonopoulos @stevepolitodesign
Prefer suspenders-main over suspenders_main
f1ed654 
Co-authored-by: Steve Polito <[email protected]>
@louis-antonopoulos @stevepolitodesign
Fix display of skip_rubocop
d2f3b66 
Co-authored-by: Steve Polito <[email protected]>
stevepolitodesign
stevepolitodesign approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@stevepolitodesign stevepolitodesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll just need to fix the linting violation.

@louis-antonopoulos louis-antonopoulos merged commit 3bc560e into main Oct 8, 2024
2 checks passed
@louis-antonopoulos louis-antonopoulos deleted the allow-running-suspenders-against-main branch October 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepolitodesign stevepolitodesign stevepolitodesign approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How do we want to handle un-released versions?
2 participants
@louis-antonopoulos @stevepolitodesign