-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mysql and sqlite3 database option bug #924
Conversation
spec/features/database_spec.rb
Outdated
context '--database=mysql' do | ||
include_context 'Project Setup Hook', '--database=mysql' | ||
|
||
it 'adds mysql2 to Gemfile' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
end | ||
|
||
context '--database=mysql' do | ||
include_context 'Project Setup Hook', '--database=mysql' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
end | ||
end | ||
|
||
context '--database=mysql' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
context '--database=sqlite3' do | ||
include_context 'Project Setup Hook', '--database=sqlite3' | ||
|
||
it 'adds sqlite3 to Gemfile' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
|
||
RSpec.describe 'Suspend a new project with custom database option' do | ||
context '--database=sqlite3' do | ||
include_context 'Project Setup Hook', '--database=sqlite3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
end | ||
|
||
RSpec.describe 'Suspend a new project with custom database option' do | ||
context '--database=sqlite3' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
end | ||
end | ||
|
||
RSpec.describe 'Suspend a new project with custom database option' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
|
||
require 'spec_helper' | ||
|
||
RSpec.shared_context 'Project Setup Hook' do |option| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
@@ -0,0 +1,34 @@ | |||
# frozen_string_literal: true | |||
|
|||
require 'spec_helper' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
context '--database=mysql' do | ||
include_context 'Project Setup Hook', '--database=mysql' | ||
|
||
it 'adds mysql2 to Gemfile' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
end | ||
|
||
context '--database=mysql' do | ||
include_context 'Project Setup Hook', '--database=mysql' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
end | ||
end | ||
|
||
context '--database=mysql' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
context '--database=sqlite3' do | ||
include_context 'Project Setup Hook', '--database=sqlite3' | ||
|
||
it 'adds sqlite3 to Gemfile' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
|
||
RSpec.describe 'Suspend a new project with custom database option' do | ||
context '--database=sqlite3' do | ||
include_context 'Project Setup Hook', '--database=sqlite3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
end | ||
|
||
RSpec.describe 'Suspend a new project with custom database option' do | ||
context '--database=sqlite3' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
end | ||
end | ||
|
||
RSpec.describe 'Suspend a new project with custom database option' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
|
||
require 'spec_helper' | ||
|
||
RSpec.shared_context 'Project Setup Hook' do |option| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/features/database_spec.rb
Outdated
@@ -0,0 +1,34 @@ | |||
# frozen_string_literal: true | |||
|
|||
require 'spec_helper' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Resolves #893 and adds support for mysql.
Running
suspenders
with the--database
option set to anything other than the default caused the following error to occur:This PR adds conditional statements to the Gemfile.erb template in order to add the appropriate gem to the Gemfile.