New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mysql and sqlite3 database option bug #924

Closed

edgarlepe wants to merge 2 commits into thoughtbot:master from edgarlepe:database-options

edgarlepe commented Jul 21, 2018

Resolves #893 and adds support for mysql.

Running suspenders with the --database option set to anything other than the default caused the following error to occur:

Specified 'some_other_database' for database adapter, but the gem is not loaded. Add `gem 'some_other_database_gem'` to your Gemfile (and ensure its version is at the minimum required by ActiveRecord).

This PR adds conditional statements to the Gemfile.erb template in order to add the appropriate gem to the Gemfile.


          Fix mysql and sqlite3 database option bug

440da54

houndci-bot reviewed

View reviewed changes

spec/features/database_spec.rb Outdated

+                context '--database=mysql' do
+                  include_context 'Project Setup Hook', '--database=mysql'
+                  it 'adds mysql2 to Gemfile' do

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

+                end
+                context '--database=mysql' do
+                  include_context 'Project Setup Hook', '--database=mysql'

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

+                  end
+                end
+                context '--database=mysql' do

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

+                context '--database=sqlite3' do
+                  include_context 'Project Setup Hook', '--database=sqlite3'
+                  it 'adds sqlite3 to Gemfile' do

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

+              RSpec.describe 'Suspend a new project with custom database option' do
+                context '--database=sqlite3' do
+                  include_context 'Project Setup Hook', '--database=sqlite3'

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

+              end
+              RSpec.describe 'Suspend a new project with custom database option' do
+                context '--database=sqlite3' do

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

+                end
+              end
+              RSpec.describe 'Suspend a new project with custom database option' do

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated


		require 'spec_helper'

		RSpec.shared_context 'Project Setup Hook' do \|option\|

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

		@@ -0,0 +1,34 @@
		# frozen_string_literal: true

		require 'spec_helper'

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot reviewed

View reviewed changes

spec/features/database_spec.rb Outdated

+                context '--database=mysql' do
+                  include_context 'Project Setup Hook', '--database=mysql'
+                  it 'adds mysql2 to Gemfile' do

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

+                end
+                context '--database=mysql' do
+                  include_context 'Project Setup Hook', '--database=mysql'

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

+                  end
+                end
+                context '--database=mysql' do

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

+                context '--database=sqlite3' do
+                  include_context 'Project Setup Hook', '--database=sqlite3'
+                  it 'adds sqlite3 to Gemfile' do

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

+              RSpec.describe 'Suspend a new project with custom database option' do
+                context '--database=sqlite3' do
+                  include_context 'Project Setup Hook', '--database=sqlite3'

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

+              end
+              RSpec.describe 'Suspend a new project with custom database option' do
+                context '--database=sqlite3' do

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

+                end
+              end
+              RSpec.describe 'Suspend a new project with custom database option' do

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated


		require 'spec_helper'

		RSpec.shared_context 'Project Setup Hook' do \|option\|

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

spec/features/database_spec.rb Outdated

		@@ -0,0 +1,34 @@
		# frozen_string_literal: true

		require 'spec_helper'

houndci-bot Jul 21, 2018

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.


          Change to double-quoted strings

4f670ac

edgarlepe closed this

edgarlepe deleted the database-options branch

July 26, 2018 06:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet