Custom actions review 2 #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reordered custom actions to bring callback actions to the second slot
Moved the instructions for creating URL and Callback actions into this page from their respective pages
Moved creation to the other page
Moved creation to the other page
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Clarified the description of URL custom actions, added note that they have a flaw in terms of UI response for the user
|
Continued clean-up of the custom actions documentation to reflect how they are actually used in practice. Moved all the details on defining them into one page, and emphasized callback actions which is all anyone ever uses. Probably could use one more round on the code samples themselves but that's a bigger project |
| @@ -57,11 +57,11 @@ | |||
| **** link:{{navprefix}}/events-app-integration[Events and app interactions] | |||
| **** link:{{navprefix}}/custom-action-intro[Custom actions] | |||
| ***** link:{{navprefix}}/customize-actions[Create and manage custom actions] | |||
| ***** link:{{navprefix}}/custom-action-callback[Callback actions] | |||
| ***** link:{{navprefix}}/edit-custom-action[Set the position of a custom action] | |||
| ***** link:{{navprefix}}/add-action-viz[Add a local action to a visualization] | |||
| ***** link:{{navprefix}}/add-action-worksheet[Add a local action to a worksheet] | |||
| ***** link:{{navprefix}}/custom-action-url[URL actions] | |||
There was a problem hiding this comment.
I think we should place URL actions above "Set position of custom action" and "Callback response payload" below "Callback actions".
There was a problem hiding this comment.
No one ever uses URL actions because of a some flaws in the design, that's why I have them placed so low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional updates to the Custom Actions docs