Rename '--config' to '--extra-settings' for clarity and avoid conflicts #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around 'django-configurations' interception of arguments which are contractions of its '--configuration' argument. We also take the opportunity to slightly clarify the name of this argument. See jazzband/django-configurations#343
Also clarify how these settings are applied.
lirsacc
approved these changes
Sep 7, 2022
Co-authored-by: Charles Lirsac <[email protected]>
Yeah, that might be better. I expect it would need to be Will revisit this before merging tomorrow. |
|
I've improved the inline documentation of the CLI arguments, but I'm going to stick with the name for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around
django-configurationsinterception of arguments which are contractions of its--configurationargument (jazzband/django-configurations#343).We also take the opportunity to slightly clarify the name of this argument.
Have tested locally that the impacted commands still behave as expected using the new spelling of the argument.