Skip to content

Commit

Permalink
TSL: Prevent viewportBottomLeft breaking change and cleanup (#1208)
Browse files Browse the repository at this point in the history
* Update three.js

* Add examples

* Update patch and delete examples
  • Loading branch information
Methuselah96 committed Aug 26, 2024
1 parent e916f03 commit 7696299
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 5 deletions.
8 changes: 4 additions & 4 deletions examples-testing/changes.patch
Original file line number Diff line number Diff line change
Expand Up @@ -14750,7 +14750,7 @@ index 432d641a..1434cc30 100644
const params = {
distanceExponent: 1,
diff --git a/examples-testing/examples/webgpu_postprocessing_bloom.ts b/examples-testing/examples/webgpu_postprocessing_bloom.ts
index f1819db4..f8c8cf06 100644
index d38a7abb..80478cf8 100644
--- a/examples-testing/examples/webgpu_postprocessing_bloom.ts
+++ b/examples-testing/examples/webgpu_postprocessing_bloom.ts
@@ -1,4 +1,4 @@
Expand Down Expand Up @@ -14783,7 +14783,7 @@ index f1819db4..f8c8cf06 100644
clock = new THREE.Clock();

diff --git a/examples-testing/examples/webgpu_postprocessing_bloom_emissive.ts b/examples-testing/examples/webgpu_postprocessing_bloom_emissive.ts
index 97186836..583a9eb3 100644
index 3cec4ebe..a0584093 100644
--- a/examples-testing/examples/webgpu_postprocessing_bloom_emissive.ts
+++ b/examples-testing/examples/webgpu_postprocessing_bloom_emissive.ts
@@ -1,4 +1,4 @@
Expand All @@ -14804,7 +14804,7 @@ index 97186836..583a9eb3 100644
init();

diff --git a/examples-testing/examples/webgpu_postprocessing_bloom_selective.ts b/examples-testing/examples/webgpu_postprocessing_bloom_selective.ts
index c180acb1..60fd7075 100644
index 066a4766..6ce4437c 100644
--- a/examples-testing/examples/webgpu_postprocessing_bloom_selective.ts
+++ b/examples-testing/examples/webgpu_postprocessing_bloom_selective.ts
@@ -1,5 +1,5 @@
Expand All @@ -14815,7 +14815,7 @@ index c180acb1..60fd7075 100644

import { OrbitControls } from 'three/addons/controls/OrbitControls.js';

@@ -87,9 +87,10 @@ window.addEventListener('pointerdown', event => {
@@ -84,9 +84,10 @@ window.addEventListener('pointerdown', event => {
const intersects = raycaster.intersectObjects(scene.children, false);

if (intersects.length > 0) {
Expand Down
1 change: 1 addition & 0 deletions types/three/src/nodes/Nodes.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ export { default as ViewportDepthTextureNode, viewportDepthTexture } from "./dis
export {
default as ViewportNode,
viewport,
viewportBottomLeft,
viewportCoordinate,
ViewportNodeScope,
viewportResolution,
Expand Down
5 changes: 5 additions & 0 deletions types/three/src/nodes/display/ViewportNode.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,8 @@ export const viewportUV: ShaderNodeObject<ViewportNode>;
* @deprecated "viewportTopLeft" is deprecated. Use "viewportUV" instead.
*/
export const viewportTopLeft: ShaderNodeObject<ViewportNode>;

/**
* @deprecated "viewportBottomLeft" is deprecated. Use "viewportUV.flipY()" instead.
*/
export const viewportBottomLeft: ShaderNodeObject<ViewportNode>;

0 comments on commit 7696299

Please sign in to comment.