Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Matrix3/4 makeTranslation types #488

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Fix Matrix3/4 makeTranslation types #488

merged 1 commit into from
Jun 30, 2023

Conversation

puxiao
Copy link
Contributor

@puxiao puxiao commented Jun 30, 2023

https://threejs.org/docs/index.html#api/en/math/Matrix4.makeTranslation

makeTranslation( x, y, z ) {

		if ( x.isVector3 ) {

			this.set(
				1, 0, 0, x.x,
				0, 1, 0, x.y,
				0, 0, 1, x.z,
				0, 0, 0, 1

			);

		} else { 
			...
		}
}

@puxiao puxiao mentioned this pull request Jun 30, 2023
Closed
Methuselah96
Methuselah96 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit 34f5d4e into three-types:dev Jun 30, 2023
@Methuselah96 Methuselah96 mentioned this pull request Jun 30, 2023
Closed
45 tasks
@puxiao puxiao deleted the dev branch June 30, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Methuselah96 Methuselah96 Methuselah96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puxiao @Methuselah96