Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSM: Remove default value of data ctor parameter. #492

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

Methuselah96
Copy link
Contributor

Why

Make changes in r153 corresponding to mrdoob/three.js#25968.

What

Make data mandatory.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@Methuselah96 Methuselah96 mentioned this pull request Jun 30, 2023
45 tasks
@Methuselah96 Methuselah96 merged commit d484779 into dev Jun 30, 2023
@Methuselah96 Methuselah96 deleted the csm-mandatory branch June 30, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant