Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Introduce OutputPass. #512

Merged
merged 4 commits into from
Jul 4, 2023
Merged

Examples: Introduce OutputPass. #512

merged 4 commits into from
Jul 4, 2023

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Jul 1, 2023 •
edited
Loading

Types provided by @gloriousjob in DefinitelyTyped/DefinitelyTyped#65939 (comment). Thanks!

Why

Make type changes corresponding to mrdoob/three.js#26102,

What

Add OutputPass and OutputShader classes.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@Methuselah96 Methuselah96 mentioned this pull request Jul 1, 2023
Merged
7 tasks
gloriousjob
gloriousjob approved these changes Jul 1, 2023
View reviewed changes
Copy link

@gloriousjob gloriousjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this review! I'm glad you caught the optional in the constructor as well.

@Methuselah96 Methuselah96 merged commit d34b4c9 into master Jul 4, 2023
@Methuselah96 Methuselah96 deleted the output-pass branch July 4, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gloriousjob gloriousjob gloriousjob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Methuselah96 @gloriousjob