Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend WebGLMultipleRenderTargets from WebGLRenderTarget #519

Merged
merged 6 commits into from
Jul 4, 2023
Merged

Extend WebGLMultipleRenderTargets from WebGLRenderTarget #519

merged 6 commits into from
Jul 4, 2023

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Jul 2, 2023 •
edited
Loading

Why

Resolves #282.

What

Extend WebGLMultipleRenderTargets from WebGLRenderTarget and make the texture property generic (defaulted to Texture) since that's how it's used most often.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@Methuselah96 Methuselah96 mentioned this pull request Jul 2, 2023
Open
3 tasks
@Methuselah96 Methuselah96 merged commit 6e862e7 into master Jul 4, 2023
3 checks passed
@Methuselah96 Methuselah96 deleted the webgl-render-target branch July 4, 2023 18:06
@CodyJasonBennett CodyJasonBennett mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebGLMultipleRenderTargets extends wrong class
1 participant
@Methuselah96