Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RMB tester #205

Merged
merged 13 commits into from
Dec 19, 2024
Merged

Fix RMB tester #205

merged 13 commits into from
Dec 19, 2024

Conversation

sameh-farouk
Copy link
Member

@sameh-farouk sameh-farouk commented Dec 12, 2024

What's Changed:

  • Changes to the RMB Tester:

    • Fix the PythonValue error when printing the results.
    • Add a clear visual indicator for the outcome and show the percentage of failures.
    • Minor refactor.
  • Changes to test_live_nodes.sh script:

    • Use zos.system.version instead of rmb.version to test live nodes (since Zos nodes no longer use the rust RMB client that used to have that command).
    • Ensure a single RMB-peer instance runs during the test.
    • Minor refactoring and improvement.

Related Issues:

@sameh-farouk
Copy link
Member Author

a quick test for all networks

redis-server starting ..
Removes all keys in Redis
OK
rmb-peer starting (devnet)..
rmb_tester starting ..
Sending ..   |████████████████████████████████████████| 1/1 [100%] in 0.0s (34.87/s) 
Waiting ..   |████████████████████████████████████████| 31/31 [100%] in 5.1s (6.12/s) 
=======================
Summary:
=======================
sent: 1
expected_responses: 31
received_success: 31
received_errors: 0
no response errors (client give up): 0
twins not responding (twin IDs): 
elapsed time: 5.147843592996651
🎉 All responses received successfully! 🎉
=======================
stop all bash managed jobs
redis-server starting ..
Removes all keys in Redis
OK
rmb-peer starting (qanet)..
rmb_tester starting ..
Sending ..   |████████████████████████████████████████| 1/1 [100%] in 0.0s (34.84/s) 
Waiting ..   |████████████████████████████████████████| 5/5 [100%] in 1.2s (4.30/s) 
=======================
Summary:
=======================
sent: 1
expected_responses: 5
received_success: 5
received_errors: 0
no response errors (client give up): 0
twins not responding (twin IDs): 
elapsed time: 1.2429287810009555
🎉 All responses received successfully! 🎉
=======================
stop all bash managed jobs
redis-server starting ..
Removes all keys in Redis
OK
rmb-peer starting (testnet)..
rmb_tester starting ..
Sending ..   |████████████████████████████████████████| 1/1 [100%] in 0.0s (34.77/s) 
Waiting ..   |████████████████████████████████████████| 26/26 [100%] in 5.7s (4.54/s) 
=======================
Summary:
=======================
sent: 1
expected_responses: 26
received_success: 26
received_errors: 0
no response errors (client give up): 0
twins not responding (twin IDs): 
elapsed time: 5.812582165002823
🎉 All responses received successfully! 🎉
=======================
stop all bash managed jobs
redis-server starting ..
Removes all keys in Redis
OK
rmb-peer starting (mainnet)..
rmb_tester starting ..
Sending ..   |████████████████████████████████████████| 1/1 [100%] in 0.0s (32.82/s) 
Waiting ..   |███████████████████████████████████████▍⚠︎ (!) 1331/1350 [99%] in 6:40.1 (3.33/s) 
Timeout reached, stopping waiting for responses.
=======================
Summary:
=======================
sent: 1
expected_responses: 1350
received_success: 1331
received_errors: 0
no response errors (client give up): 19
twins not responding (twin IDs): 11906 4359 3596 2445 3345 5905 11156 6811 2086 12584 9012 2107 2369 8003 2891 6477 5974 7032 4860
elapsed time: 400.2224214730013
⚠ Warning: 1.41% of responses are missing! ⚠
=======================
stop all bash managed jobs

@ashraffouda
Copy link
Contributor

tried it from ur branch on devenet and testnet and it gives 0 successful responses,can u recheck it again maybe something wrong from my side
devnet
image
testnet
image

@sameh-farouk
Copy link
Member Author

sameh-farouk commented Dec 16, 2024

In your screenshots, the rmb-peer binary did not start, which is the reason for the issue. What is the content of the log file rmb-peer.log?

@ashraffouda
Copy link
Contributor

ok, it was my fault I exported MNEMONICS instead of MNEMONIC I suggest u fail with a clear msg if MNEMONIC=""
something like what u r doing if the script started without passing a network
image

@ashraffouda
Copy link
Contributor

nice

@ashraffouda ashraffouda merged commit 09896bf into main Dec 19, 2024
1 check passed
@ashraffouda ashraffouda deleted the main-fix-rmb-tester branch December 19, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants