-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting deployments on zos4 nodes #3497
Conversation
…m and wireguard to filters in all solutions
…ethods to support zos4 deployments
…ork light primitive
…yment, removing unnecessary comments and adding descriptive ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial review will continue tmw
packages/playground/src/components/node_selector/TfManualNodeSelector.vue
Outdated
Show resolved
Hide resolved
packages/playground/src/components/node_selector/TfManualNodeSelector.vue
Show resolved
Hide resolved
packages/playground/src/components/node_selector/TfManualNodeSelector.vue
Show resolved
Hide resolved
@@ -142,6 +142,7 @@ class MachineModel { | |||
@Expose() @IsInt() @IsOptional() solutionProviderId?: number; | |||
@Expose() @IsString() @IsOptional() zlogsOutput?: string; | |||
@Expose() @IsString({ each: true }) @IsOptional() gpus?: string[]; | |||
@Expose() @IsString({ each: true }) @IsOptional() features?: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we do as it might be used like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned before, I think we should have an enum for the possible values inside the array
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use the feature type here instead of the string ?
…n AddMachine filters and moving getFeatures method to utils
this issue is till present too, only on your pr, please fix it |
This comment was marked as outdated.
This comment was marked as outdated.
some tests are failing with me too |
Those tests are already failing on
|
https://github.com/threefoldtech/tfgrid-sdk-ts/runs/35015478469 |
I seems mycelium is not stable; I can't complete the verification |
…ing workloadTypes enum and adding a semi-fix to loadgateway nodes
… loop when loading gateway nodes
Those tests are alreadu failing on development branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the great work and the effort @maayarosama
some testing notes
- all the zos4 nodes are dedicated so we have to rent them.
- it list the nodes based on the features = mycelium, if no nodes zos4 available it will deploy as zmachine
- node 259 is not stable
- manual selection works fine if you select zoo4 node with ipv4 will show an error -
- able to list all deployments the light and the normal - able to delete the deployment contracts;
- I wasn’t able to access the vmd via mycelium always, mycelium is not stable even on the normal vis
- testing domain name is not possible
- main net have only 5 gateway nodes so I’m not able to test the filtering logic
- some case related to network accessibility are not tested due to the instability of myceluim
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scripts work, error in domain selection is gone
opened an issue for this enhancement #3806 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opened issue for an enhancement. Otherwise, lgtm, great work! :) <3
Description
Supporting deployments on zos4 nodes from grid client and dashboard
Changes
Related Issues
Tested Scenarios
Node 168 which is a zos3 node
Node 255 which is a zos4 node
Go to Dashboard
Go to Dashboard
Checklist