Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment list #3543

Merged
merged 9 commits into from
Oct 29, 2024
Prev Previous commit
Next Next commit
fix: Prevent race condition in deployment deletion:
- Replaced `Promise.all` with a `.reduce()` approach to sequentially await each `deleteDeployment` and `deleteGatewayDeployment` call.
Mahmoud-Emad committed Oct 27, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 738a9045819745a78e97f60502edff13fe612157
44 changes: 22 additions & 22 deletions packages/playground/src/weblets/tf_deployment_list.vue
Original file line number Diff line number Diff line change
@@ -512,29 +512,29 @@ async function onDelete(k8s = false) {
}
});

await Promise.all(
allSelectedItems.map(async item => {
try {
if (projectNameLower === ProjectName.Domains.toLowerCase()) {
await deleteGatewayDeployment(
updateGrid(grid, { projectName: projectNameLower }),
item[0].workloads[0].name as string,
);
} else {
await deleteDeployment(updateGrid(grid!, { projectName: item.projectName }), {
deploymentName: item.deploymentName,
name: k8s ? item.deploymentName : item.name,
projectName: item.projectName,
ip: item.interfaces?.[0]?.ip,
k8s,
});
}
} catch (e: any) {
createCustomToast(`Failed to delete deployment with name: ${item.name}`, ToastType.danger);
console.error("Error while deleting deployment", e.message);
await allSelectedItems.reduce(async (acc, item) => {
await acc;
try {
if (projectNameLower === ProjectName.Domains.toLowerCase()) {
await deleteGatewayDeployment(
updateGrid(grid, { projectName: projectNameLower }),
item[0].workloads[0].name as string,
);
} else {
await deleteDeployment(updateGrid(grid!, { projectName: item.projectName }), {
deploymentName: item.deploymentName,
name: k8s ? item.deploymentName : item.name,
projectName: item.projectName,
ip: item.interfaces?.[0]?.ip,
k8s,
});
}
}),
);
} catch (e: any) {
createCustomToast(`Failed to delete deployment with name: ${item.name}`, ToastType.danger);
console.error("Error while deleting deployment", e.message);
}
}, Promise.resolve());

table.value?.loadDeployments();
} catch (e) {
createCustomToast((e as Error).message, ToastType.danger);
Loading