Fix zmount test cases #3608
Fix zmount test cases #3608
Conversation
samaradel
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar and
0oM4R
as code owners
|
|
||
| expect(result).toThrow(); | ||
| expect(result).toBe(size.toString()); |
There was a problem hiding this comment.
can directly do expect(zmount.challenge()).toBe....
|
|
||
| expect(result).toThrow(); | ||
| expect(result).toBe(size.toString()); | ||
| }); | ||
|
|
||
| test("Max value for size.", () => { | ||
| const size = 100 * 1025 ** 4; |
There was a problem hiding this comment.
What do these numbers mean? try extracting to a const
| max: "size must not be greater than 10995116277760", | ||
| }, | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| test("Size doesn't accept decimal value.", () => { | ||
| const size = 1.5; |
| min: "size must not be less than 104857600", | ||
| }, | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| test("Size empty value.", () => { |
There was a problem hiding this comment.
While we are at it, check against null, undefined, NaN, {} , and []
| }).toThrow( | ||
| expect.objectContaining({ | ||
| constraints: { | ||
| max: "size must not be greater than 10995116277760", |
There was a problem hiding this comment.
check against the boundaries max, and min
and off by 1 min - 1 and max+1
| const result = () => zmount.challenge(); | ||
| it("should fail validation if size is greater than the maximum", async () => { | ||
| // Greater than 10 TB | ||
| expect(() => (zmount.size = 15 * 1024 ** 4)).toThrow(); |
There was a problem hiding this comment.
define the min and max as constants before any of the tests
|
please place the min and max values in a constant before any of the tests. Please move tests that check if size is null, Nan or not an int before the min and max tests |
| const minSize = 50 * 1024 ** 2; // Less than 100 MB | ||
| const maxSize = 15 * 1024 ** 4; // Greater than 10 TB | ||
| const validSize = 5 * 1024 ** 3; |
There was a problem hiding this comment.
it's better to have a random size (within a certain range) to test with
you can use this method to generate the random number
| let zmount: Zmount; | ||
| const minSize = 50 * 1024 ** 2; // Less than 100 MB | ||
| const maxSize = 15 * 1024 ** 4; // Greater than 10 TB | ||
| const validSize = 5 * 1024 ** 3; |
There was a problem hiding this comment.
Why are we initializing this with a value, if we're using getRandomNumber
|
|
||
| expect(result).toThrow(); | ||
| const result = zmount.challenge(); | ||
| expect(typeof result).toBe("string"); |
There was a problem hiding this comment.
you can cast validSize to string and check against its value
Description
Fix zmount test suite expected errors.
Changes
Related Issues
Tested Scenarios
Checklist