change url for terms and conditions from threefold library to manual

[mik-tf]

Description

• Changed the URL for the Terms and Conditions from Library to Manual

Related Issues

• Update Links for T&C on Dashboard #3686

Preliminary Checks:

• Does it completely address the issue linked?
  • IMO, it should work but please test.

Checklist

• Tests included
• Build pass
• Documentation
• Code format and docstrings
• Screenshots/Video attached (needed for UI changes)

[0oM4R]

we should have this update in dashboard as well,

tfgrid-sdk-ts/packages/playground/src/weblets/profile_manager.vue

Lines 859 to 876 in 4e2fc0b

	function parseAcceptTermsLink(tempDiv: HTMLDivElement) {
	const url = "https://library.threefold.me/info/legal#";
	const linkElements = tempDiv.querySelectorAll("a");
	linkElements.forEach(linkElement => {
	const currentDomainMatch = linkElement.href.match(/^(https?:\/\/[^\\/]+)/);
	if (
	(currentDomainMatch && linkElement.href.includes("localhost")) ||
	(currentDomainMatch && linkElement.href.includes("dashboard")) // To update only internal links
	) {
	const currentDomain = currentDomainMatch[1];
	linkElement.href = linkElement.href.replace(currentDomain, url);
	}
	});
	}
	watch(openAcceptTerms, async () => {
	if (openAcceptTerms.value) {
	try {
	const url = "https://library.threefold.me/info/legal/";

[mik-tf]

@0oM4R I updated the two URLs from library to manual.

LMK if it's OK. And feel free to test it on your end. Thanks.

[maayarosama]

The terms and condition page can't be retrieved and when I press accept terms and conditions it fails
dashboard (2).log

[0oM4R]

it wont work; i think we should have markdown file to be able to parse it

[0oM4R]

also looks like the host have cors error

[0oM4R]

CORS error resolved, we may see the error as the current appends readme.md to the link, if you commented this part you will not face the cors error again, but the content will be shown as html file

[0oM4R]

@mik-tf Can we mark this PR as a draft until the comments get resolved?

[mik-tf]

@0oM4R Of course. Done.

[mik-tf]

@0oM4R as I understand, the issue on cors has been resolved. I'll wait for your input before setting it to Ready to review, to be sure. Thanks.

[0oM4R]

@0oM4R as I understand, the issue on cors has been resolved. I'll wait for your input before setting it to Ready to review, to be sure. Thanks.
@mik-tf
already reviewed the pr and mentioned the current issue on #3687 (comment)

[maayarosama]

The related issue's state is accepted, shouldn't this pr be drafted?