Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment scripts for Gitea, Jenkins, Jitsi, and Nostr #3689

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

khaledyoussef24
Copy link
Contributor

@khaledyoussef24 khaledyoussef24 commented Dec 1, 2024

Description

Added grid client scripts for the new solutions in the dashboard
#3330

adding scripts for

  • Gitea
  • Jenkins
  • Jitsi
  • Nostr

Changes

List of changes this PR includes

Related Issues

List of related issues

Tested Scenarios

A list of scenarios tried to match the deliverables

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

To consider

Preliminary Checks:

  • Does it completely address the issue linked?
  • What about edge cases?
  • Does it meet the specified acceptance criteria?
  • Are there any unintended side effects?
  • Does the PR adhere to the team's coding conventions, style guides, and best practices?
  • Does it integrate well with existing features?
  • Does it impact the overall performance of the application?
  • Are there any bottlenecks or slowdowns?
  • Has it been optimized for efficiency?
  • Has it been adequately tested with unit, integration, and end-to-end tests?
  • Are there any known defects or issues?
  • Is the code well-documented?
  • Are changes to documentation reflected in the code?

UI Checks:

  • If a UI design is provided/ does it follow it?
  • Does every button work?
  • Is the data displayed logical? Is it what you expected?
  • Does every validation work?
  • Does this interface feel intuitive?
  • What about slow network? Offline?
  • What if the gridproxy/graphql/chain is failing?
  • What would a first time user have a hard time navigating here?

Code Quality Checks:

  • Code formatted/linted? Are there unused imports? .. etc
  • Is there redundant/repeated code?
  • Are there conditionals that are always true or always false?
  • Can we write this more concisely?
  • Can we reuse this code? If yes, where?
  • Will the changes be easy to maintain and update in the future?
  • Can this code become too complex to understand for other devs?
  • Can this code cause future integration problems?

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a Gateway Timeout when trying to access an instance deployed from with the script https://gt79newgitea.gent01.dev.grid.tf , https://gt79newgitea2.gent01.dev.grid.tf/
while everything works fine when deploying from the dashboard https://gt79gtett7l.gent01.dev.grid.tf/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will check the scripts and try the deployment again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed resolve but it only works with public ip

@0oM4R
Copy link
Contributor

0oM4R commented Dec 15, 2024

as @khaledyoussef24 request will convert it to draft

@0oM4R 0oM4R marked this pull request as draft December 15, 2024 11:17
@khaledyoussef24
Copy link
Contributor Author

khaledyoussef24 commented Dec 17, 2024

Work in progress

  • made the deployment of gitea to work on public ip
  • tried and debugged every proccess to make it run using mycelium but didnot work (has an issue in deploying the gateway connected on port 3000 which is not allowed in the image it self)
  • tried many work arounds like enabling the port while deploying using script or using the entrypoint but did not work out and would not be the best implementations)
  • test jenkins working fine
  • jitsi is configured right and checked it
  • nostor also works fine

@khaledyoussef24 khaledyoussef24 marked this pull request as ready for review December 18, 2024 07:51
name: subdomain,
node_id: gatewayNode.nodeId,
tls_passthrough: false,
backends: [`http://[${VMmyceliumIP}]:3000`],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This results in an error since you removed VMmyceliumIP

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nostor is giving me bad gateway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants