Add rentableOrRentedBy query in dedicated filter #3740
+25
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaradel
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar and
0oM4R
as code owners
|
cpd from #3587 |
0oM4R
reviewed
Dec 16, 2024
There was a problem hiding this comment.
#3587 (review)
still reproducable
also there are many unrelated changes please make sure to update the pr
|
Please remove unrelated changes |
5 tasks
|
it correctly shows my rented node along with any rentable node in the node selector in deployment shouldn't the error be shown in node selector and deployment prevented if node is not rented by you? |
|
@amiraabouhadid fixed, please check the attached video |
0oM4R
requested changes
Jan 2, 2025
| @@ -224,6 +224,9 @@ export async function validateRentContract( | |||
| } | |||
|
|
|||
| try { | |||
| if (node.dedicated || node.rentedByTwinId === 0) { | |||
There was a problem hiding this comment.
i think it should be and
I'm already reting node 151 but got this error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rentableOrRentedByquery in the dedicated filter.Changes
Screencast.from.01-01-25.14.39.41.webm
Tested Scenarios
Scenarios Update
Documentation PR
Related Issues
Checklist