Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mycelium IP column in workers table #3743

Merged
merged 8 commits into from
Dec 29, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Dec 15, 2024

Description

  • Add the MyCelium IP column in the worker's table.
  • Include myCelium in the worker deployment object.
  • Add Created At and Health columns.

Changes

image

Tested Scenarios

  • Go to Caprover solution
  • Deploy instance with worker and mycelium enabled
  • List the deployments
  • View the worker's table, the mycelium column should be there

Scenarios update

  • Create more than two workers and check that all have the mycelium IP column.
  • Create with planetary and no mycelium and check nothing in the mycelium column.
  • Delete a worker, add it again, and ensure mycelium ip changes.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel
Copy link
Contributor Author

cpd from #3590

@samaradel samaradel changed the title Development 2.7 worker with mycelium ip Add mycelium IP column in workers table Dec 15, 2024
@samaradel samaradel marked this pull request as ready for review December 18, 2024 13:08
@maayarosama
Copy link
Contributor

Shouldn't we apply this to k8s workers too?

@AhmedHanafy725
Copy link
Contributor

Shouldn't we apply this to k8s workers too?

please have a different issue for it

Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the workers table contain contract id
image

while the deployment doesn't have it should we remove it ?
image

@samaradel
Copy link
Contributor Author

@0oM4R I'm not sure, I sent the current solution to the SDK group and @AhmedHanafy725 agreed. maybe he should confirm.

@AhmedHanafy725
Copy link
Contributor

@0oM4R I'm not sure, I sent the current solution to the SDK group and @AhmedHanafy725 agreed. maybe he should confirm.

no problem, we can remove it from the table

@samaradel samaradel requested a review from 0oM4R December 29, 2024 10:51
@samaradel samaradel merged commit d1acf89 into development Dec 29, 2024
9 of 10 checks passed
@samaradel samaradel deleted the development_2.7_worker_with_myceliumIp branch December 29, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants