Skip to content

remove health filter #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

remove health filter #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions node-registrar/client/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ type NodeUpdate struct {
Virtualized *bool
SerialNumber *string
Status *string
Healthy *bool
Approved *bool
}

Expand Down Expand Up @@ -326,7 +325,6 @@ type NodeFilter struct {
FarmID *uint64
TwinID *uint64
Status *string
Healthy *bool
Online *bool
LastSeen *int64
Page *uint32
Expand Down Expand Up @@ -447,14 +445,8 @@ func (c *RegistrarClient) parseUpdateNodeOpts(node Node, update NodeUpdate) Node
if update.Virtualized != nil {
node.Virtualized = *update.Virtualized
}
if update.Status != nil {
node.Virtualized = *update.Virtualized
}
if update.Healthy != nil {
node.Virtualized = *update.Virtualized
}
if update.Approved != nil {
node.Virtualized = *update.Virtualized
node.Approved = *update.Approved
}

return node
Expand All @@ -475,9 +467,6 @@ func parseListNodeOpts(filter NodeFilter) map[string]any {
if filter.Status != nil && *filter.Status != "" {
data["status"] = *filter.Status
}
if filter.Healthy != nil {
data["healthy"] = *filter.Healthy
}
if filter.Online != nil {
data["online"] = *filter.Online
}
Expand Down
6 changes: 0 additions & 6 deletions node-registrar/docs/docs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,12 +464,6 @@ const docTemplate = `{
"name": "status",
"in": "query"
},
{
"type": "boolean",
"description": "Filter by health status",
"name": "healthy",
"in": "query"
},
{
"type": "boolean",
"description": "Filter by online status (true = online, false = offline)",
Expand Down
6 changes: 0 additions & 6 deletions node-registrar/docs/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,12 +457,6 @@
"name": "status",
"in": "query"
},
{
"type": "boolean",
"description": "Filter by health status",
"name": "healthy",
"in": "query"
},
{
"type": "boolean",
"description": "Filter by online status (true = online, false = offline)",
Expand Down
4 changes: 0 additions & 4 deletions node-registrar/docs/swagger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,10 +537,6 @@ paths:
in: query
name: status
type: string
- description: Filter by health status
in: query
name: healthy
type: boolean
- description: Filter by online status (true = online, false = offline)
in: query
name: online
Expand Down
1 change: 0 additions & 1 deletion node-registrar/pkg/db/models.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ type NodeFilter struct {
FarmID *uint64 `form:"farm_id"`
TwinID *uint64 `form:"twin_id"`
Status string `form:"status"`
Healthy bool `form:"healthy"`
Online *bool `form:"online"` // Filter by online status (true = online, false = offline, nil = both)
LastSeen *int64 `form:"last_seen"` // Filter nodes last seen within this many minutes
}
Expand Down
1 change: 0 additions & 1 deletion node-registrar/pkg/server/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ func (s Server) updateFarmHandler(c *gin.Context) {
// @Param farm_id query int false "Filter by farm ID"
// @Param twin_id query int false "Filter by twin ID"
// @Param status query string false "Filter by status"
// @Param healthy query bool false "Filter by health status"
// @Param online query bool false "Filter by online status (true = online, false = offline)"
// @Param last_seen query int false "Filter nodes last seen within this many minutes"
// @Param page query int false "Page number" default(1)
Expand Down
Loading