don't check the passed version if we are in 1st stage #2408
Conversation
Signed-off-by: Ashraf Fouda <[email protected]>
ashraffouda
requested review from
muhamadazmy,
delandtj,
mariobassem,
rawdaGastan and
xmonader
as code owners
|
@ashraffouda maybe add the context/reason of this change? |
bootstrap running in two stages, during 1st stage bootstrap only upgrades itself so if we added a new version like v4 in bootstrap and the running image has old version of bootstrap it will fail because bootstrap doesn't know the new version at the 1st stage, so it first needs to run and update itself to get the new changes which contains the newly added version |
| @@ -119,12 +119,15 @@ impl Config { | |||
| if stage == 0 { | |||
| bail!("invalid stage value 0, stages starting from 1"); | |||
| } | |||
|
|
|||
| let mut ver = Version::V3; | |||
There was a problem hiding this comment.
So, looks like it will become the version latest-1?
what happens when we upgrade zos with latest - 2 or latest version?
In this context, it means v2 or v4
There was a problem hiding this comment.
at 1st step we set it to v3 this is the current supported version so it will not fail at 1st step
…2408) Signed-off-by: Ashraf Fouda <[email protected]>
Description
don't consider version in first stage of bootstrap
Changes
skip passed version if bootstrap is running in 1st stage
Related Issues
List of related issues
Checklist