Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: David Núñez <[email protected]>
Co-authored-by: Derek Pierre <[email protected]>
  • Loading branch information
3 people authored Nov 14, 2023
1 parent 81dd1eb commit 9704156
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions contracts/staking/IApplicationWithDecreaseDelay.sol
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ interface IApplicationWithDecreaseDelay is IApplication {
/// so that operator can participate in the application.
/// @return authorizationDecreaseDelay Delay in seconds that needs to pass
/// between the time authorization decrease is requested and the
/// time that request gets approved. Protects against free-riders
/// time that request gets approved. Protects against participants
/// earning rewards and not being active in the network.
/// @return authorizationDecreaseChangePeriod Authorization decrease change
/// period in seconds. It is the time, before authorization decrease
/// delay end, during which the pending authorization decrease
/// period in seconds. It is the time window, before authorization decrease
/// delay ends, during which the pending authorization decrease
/// request can be overwritten.
/// If set to 0, pending authorization decrease request can not be
/// overwritten until the entire `authorizationDecreaseDelay` ends.
/// If set to value equal `authorizationDecreaseDelay`, request can
/// If set to a value equal to `authorizationDecreaseDelay`, request can
/// always be overwritten.
function authorizationParameters()
external
Expand Down
4 changes: 2 additions & 2 deletions contracts/staking/IApplicationWithOperator.sol
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ interface IApplicationWithOperator is IApplication {
returns (address);

/// @notice Used by staking provider to set operator address that will
/// operate a node. The operator addressmust be unique.
/// operate a node. The operator address must be unique.
/// Reverts if the operator is already set for the staking provider
/// or if the operator address is already in use.
/// @dev Depending on application the given staking provider can set operator
/// address only one or multiple times. Besides that application can decide
/// address only once or multiple times. Besides that, application can decide
/// if function reverts if there is a pending authorization decrease for
/// the staking provider.
function registerOperator(address operator) external;

Check warning on line 36 in contracts/staking/IApplicationWithOperator.sol

View workflow job for this annotation

GitHub Actions / code-lint-and-format

Function order is incorrect, external function can not go after external view function (line 23)
Expand Down

0 comments on commit 9704156

Please sign in to comment.