Redemption- select wallet #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if there is a wallet in network that has enough BTC to handle a redemption request. If such a wallet exists we trigger the submit function and pass the wallet data to this function. Otherewise the function from the threshold-ts lib throws an error and we set an error message for the `amount` field.
r-czajkowski
added a commit
that referenced
this pull request
Jun 9, 2023
Add a new method to the `ITBTC` interface that requests redemption. The implementation of this interface uses the `requestRedemption` fn from `tbtc-v2.ts` lib. As a temporary soultion here we hardcode the redemption request data in component- once we merge the #532 we will pass these params via props to the component.
Merged
To request redemption we need the wallet public key(compressed public key of the ECDSA Wallet) instead of hash. Here we update wallet data prop field name to point out that this is a wallet public key not wallet public key hash.
There was a problem hiding this comment.
LGTM 🔥
Tested it out using electrum and goerli contracts + linked tbtc-v2.ts lib and it found the wallet. Left some minor comments here and there.
Since keep-network/tbtc-v2#630 is merged then we could release the new version of tbtc-v2.ts lib and add it here to package.json before we merge it.
To use the latest redemption API.
michalsmiarowski
requested changes
Jul 10, 2023
Adjust the code to the latest changes from `tbtc-v2.ts` lib. We must pass redeemer output script to the `findWalletForRedemption` fn from the `tbtc-v2.ts` lib. In the dapp we operate on the bitcoin address so we convert this address to a script under the hood and then call the function from `tbtc-v2.ts` lib.
r-czajkowski
force-pushed
the
redemption-select-wallet
branch
from
0f3518f
to
0e3556b
Compare
michalsmiarowski
requested changes
Jul 10, 2023
Print errors that will happen on submit function above the `Unmint` button.
r-czajkowski
force-pushed
the
redemption-select-wallet
branch
from
40e4397
to
547ee40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: keep-network/tbtc-v2#630Depends on: #523Check if there is a wallet in network that has enough BTC to handle a redemption request. If such a wallet exists we trigger the submit function and pass the wallet data to this function. Otherwise, the function from the threshold-ts lib throws an error and we set an error message for the
amountfield.