Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deployment on Sepolia #605

Merged
merged 15 commits into from
Nov 23, 2023
Merged

Support deployment on Sepolia #605

merged 15 commits into from
Nov 23, 2023

Conversation

michalinacienciala
Copy link
Contributor

@michalinacienciala michalinacienciala commented Sep 5, 2023

The Görli testnet currently used by Threshold/Keep for development purposes is planned to become deprecated with the end of year 2023. The testnet that is planned to replace it is called
Holešky, however it's not yet available - it's planned it will become widely accessible on Oct 1, 2023 (source). Switching our infrastructure to support new testnet is quite time consuming, so moving directly from Görli to Holešky may be quite risky, especially if there would be some delays in the date of Holešky genesis (not meeting the planned timelines is not a rare occurrence in the Ethereum space). As a solution, we decided to switch first to another testnet that is currently live - Sepolia. This testnet's EOL is planned for 2026, which gives us plenty of time to move to Holešky before Sepolia gets deprecated.

TODO:

  • deploy merkle drop contract address on Sepolia: 0x4621a14bbB5a53f79Ea532bdc032b8ACc383B153 (deployed from the merkle-distribution repo)
  • deploy stub SimplePreApplication on Sepolia: 0x471EA40981D278fb3Cb55587e94ac549aad1ACA9 (deployed using solidity-contracts/deploy/00_resolve_nucypher_pre_application.ts, with func.skip line commented out)

NOTE: The PR will be left as draft until we have the client config switched to Sepolia

Refs:
threshold-network/solidity-contracts#150
keep-network/ci#48
threshold-network/solidity-contracts#151
keep-network/keep-core#3706
keep-network/tbtc-v2#691

The Görli testnet currently used by Threshold/Keep for development purposes is
planned to become deprecated with the end of year 2023. The testnet that is
planned to replace it is called
[Holešky](https://github.com/eth-clients/holesky), however it's not yet
available - it's planned it will become widely accessible on Oct 1, 2023
([source](https://everstake.one/blog/new-ethereum-testnet-holesky-all-you-need-to-know-now)).
Switching our infrastructure to support new testnet is quite time consuming, so
moving directly from Görli to Holešky may be quite risky, especially if there
would be some delays in the date of Holešky genesis (not meeting the planned
timelines is not a rare occurrence in the Ethereum space). As a solution, we
decided to switch first to another testnet that is currently live - Sepolia.
This testnet's EOL is planned for 2026, which gives us plenty of time to move to
Holešky before Sepolia gets deprecated.
@michalinacienciala michalinacienciala added the ☁️ infrastructure CI, Infrastructure, Workflows label Sep 5, 2023
@michalinacienciala michalinacienciala self-assigned this Sep 5, 2023
@michalinacienciala michalinacienciala marked this pull request as draft September 5, 2023 14:41
lukasz-zimnoch added a commit to keep-network/keep-core that referenced this pull request Sep 25, 2023
The Görli testnet currently used by Threshold/Keep for development
purposes is planned to become deprecated with the end of year 2023. The
testnet that is planned to replace it is called
[Holešky](https://github.com/eth-clients/holesky), however it's not yet
available - it's planned it will become widely accessible on Oct 1, 2023
([source](https://everstake.one/blog/new-ethereum-testnet-holesky-all-you-need-to-know-now)).
Switching our infrastructure to support new testnet is quite time
consuming, so moving directly from Görli to Holešky may be quite risky,
especially if there would be some delays in the date of Holešky genesis
(not meeting the planned timelines is not a rare occurrence in the
Ethereum space). As a solution, we decided to switch first to another
testnet that is currently live - Sepolia. This testnet's EOL is planned
for 2026, which gives us plenty of time to move to Holešky before
Sepolia gets deprecated.

Refs:
threshold-network/solidity-contracts#150
keep-network/ci#48
threshold-network/solidity-contracts#151
keep-network/tbtc-v2#691
threshold-network/token-dashboard#605

- [ ] Update `TESTNET_ETH_CONTRACT_OWNER_PRIVATE_KEY` so that it is
prefixed with `0x`
lukasz-zimnoch added a commit to keep-network/tbtc-v2 that referenced this pull request Oct 24, 2023
The Görli testnet currently used by Threshold/Keep for development
purposes is
planned to become deprecated with the end of year 2023. The testnet that
is
planned to replace it is called
[Holešky](https://github.com/eth-clients/holesky), however it's not yet
available - it's planned it will become widely accessible on Oct 1, 2023

([source](https://everstake.one/blog/new-ethereum-testnet-holesky-all-you-need-to-know-now)).
Switching our infrastructure to support new testnet is quite time
consuming, so
moving directly from Görli to Holešky may be quite risky, especially if
there
would be some delays in the date of Holešky genesis (not meeting the
planned
timelines is not a rare occurrence in the Ethereum space). As a
solution, we
decided to switch first to another testnet that is currently live -
Sepolia.
This testnet's EOL is planned for 2026, which gives us plenty of time to
move to
Holešky before Sepolia gets deprecated.

Refs:
threshold-network/solidity-contracts#150
keep-network/ci#48
threshold-network/solidity-contracts#151
keep-network/keep-core#3706
threshold-network/token-dashboard#605
In the commit `c58ee5c078cbe850e678b85a136a4841d1732615` we've started
modificating Token Dashboard config to make it run on the Sepolia testnet. In
this commit we continue that work. Some configs are still missing - we mark them
as TODO.
The merkle drop contract was deployed on Sepolia under the
`0x4621a14bbB5a53f79Ea532bdc032b8ACc383B153` address
(https://sepolia.etherscan.io/address/0x4621a14bbB5a53f79Ea532bdc032b8ACc383B153).
The `SimplePreApplication` stub contract was deployed on Sepolia under the
`0x471EA40981D278fb3Cb55587e94ac549aad1ACA9` address
(https://sepolia.etherscan.io/address/0x471EA40981D278fb3Cb55587e94ac549aad1ACA9).
@michalinacienciala michalinacienciala marked this pull request as ready for review November 22, 2023 13:26
We're bringing back the functionality removed in commit
17e2a0b. Recently we've changed the dapp's
`@keep-network/tbtc-v2.ts` dependency to `^2.3.0`, which results in the
introduction of the `@threshold-network/[email protected]` package in the
`yarn.lock`. That package contains a `prepare-dependencies.sh` script
which sometimes causes problems during install/upgrade of the dapp dependencies.
As a workaround we install dashboard dependencies with `--ignore-scripts` flag.
This way we don't run the misbehaving script (we don't need to run it in this
project). In order to run the postinstall scripts related strictly to the
`@threshold-network/token-dashboard` project, we manually run the post-install
script by executing `yarn run postinstall`.
The workaround for the `expected manifest` problem must resolve the
specific version for both `sepolia` and `dapp-development-sepolia` tags,
depending on the target environment.
Copy link

Copy link

1 similar comment
Copy link

@lukasz-zimnoch lukasz-zimnoch self-assigned this Nov 23, 2023
Copy link

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@lukasz-zimnoch lukasz-zimnoch merged commit ae3a434 into main Nov 23, 2023
5 checks passed
@lukasz-zimnoch lukasz-zimnoch deleted the support-sepolia branch November 23, 2023 12:46
michalsmiarowski added a commit to threshold-network/bitcoin-on-base that referenced this pull request Feb 23, 2024
Adds support for Sepolia in local development.

The support for preview and deployed testnet version will be addressed in a
separate PR.

This wa done based on the pull request from T dashbaord repo, where we did the
same: threshold-network/token-dashboard#605 (commit:
`ae3a4342e79bd822a8db6504c351dd2259d01cfe`).
@michalsmiarowski michalsmiarowski added this to the v1.14.0 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☁️ infrastructure CI, Infrastructure, Workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants