Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Thumbor 7 (and Python 3) #41

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Upgrade to Thumbor 7 (and Python 3) #41

wants to merge 11 commits into from

Conversation

scorphus
Copy link
Member

@scorphus scorphus commented Jan 31, 2022

Proposal

This PR includes several changes to the codebase not only to make it compatible with Thumbor 7 and Python 3 but also to put the project back on track.

There's some stuff left to do – I just ran out of Ben & Jerry's – but I'd love to collect early reviews, so I'm submitting this as draft.

TODO

Here's a list of things to do (there might be more) starting from the easiest:

  • Check code with linters as part of the workflow
  • Add thumbor as Git submodule and use its integration tests base structure instead of repeating content inside ./integration_tests/
  • Write unit tests (there is none)

These could also be converted into issues and tackled by any avid bootcamper.

@scorphus scorphus force-pushed the py3-thumbor7 branch 2 times, most recently from 263c60f to 7296c3c Compare January 31, 2022 23:04
@scorphus scorphus linked an issue Jan 31, 2022 that may be closed by this pull request
@neilsh
Copy link

neilsh commented Mar 1, 2023

I know this hasn't been worked on recently @scorphus , but were there any known issues/incompatibilities? I'm currently upgrading an internal codebase that uses opencv-engine from Thumbor 6->7, and was wondering if this would be suitable for use. If there's any known issues I can take a crack at resolving them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to thumbor 7
2 participants