BotoParallelReader bug #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
thunder/readers.py
Outdated
| key = bucket.get_key(keyName) | ||
| buf = key.get_contents_as_string() | ||
| yield idx, buf | ||
| yield idx, buf, keyName |
|
Looks good @boazmohar ! Just a style nit. Thanks for catching this. I think #327 was a different error though. |
|
Sure thing @freeman-lab I prefer finding the bugs I made first :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to run
data = td.images.fromexample(name='mouse',engine=None)fails due to a change from #313 as the accessor function expects 3 params.
This PR fixes that, still don't know if related to #327
There are no tests for the BotoParallelReader, seems very hard to mock AWS.
@freeman-lab Is there another way?