Skip to content

Commit

Permalink
This is an automated cherry-pick of tikv#8264
Browse files Browse the repository at this point in the history
close tikv#8263

Signed-off-by: ti-chi-bot <[email protected]>
  • Loading branch information
lhy1024 authored and ti-chi-bot committed Aug 27, 2024
1 parent fcb34c9 commit 247158f
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 0 deletions.
5 changes: 5 additions & 0 deletions pkg/schedule/operator/operator_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,13 @@ func (oc *Controller) checkAddOperator(isPromoting bool, ops ...*Operator) (bool
operatorCounter.WithLabelValues(op.Desc(), "unexpected-status").Inc()
return false, NotInCreateStatus
}
<<<<<<< HEAD
if !isPromoting && oc.wopStatus.ops[op.Desc()] >= oc.config.GetSchedulerMaxWaitingOperator() {
log.Debug("exceed max return false", zap.Uint64("waiting", oc.wopStatus.ops[op.Desc()]), zap.String("desc", op.Desc()), zap.Uint64("max", oc.config.GetSchedulerMaxWaitingOperator()))
=======
if !isPromoting && oc.wopStatus.getCount(op.Desc()) >= oc.config.GetSchedulerMaxWaitingOperator() {
log.Debug("exceed max return false", zap.Uint64("waiting", oc.wopStatus.getCount(op.Desc())), zap.String("desc", op.Desc()), zap.Uint64("max", oc.config.GetSchedulerMaxWaitingOperator()))
>>>>>>> e767c012f (schedule: fix datarace in `operator.check` (#8264))
operatorCounter.WithLabelValues(op.Desc(), "exceed-max-waiting").Inc()
return false, ExceedWaitLimit
}
Expand Down
27 changes: 27 additions & 0 deletions pkg/schedule/operator/operator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ package operator
import (
"context"
"encoding/json"
<<<<<<< HEAD

Check failure on line 20 in pkg/schedule/operator/operator_test.go

View workflow job for this annotation

GitHub Actions / statics

missing import path
"fmt"
=======
>>>>>>> e767c012f (schedule: fix datarace in `operator.check` (#8264))
"sync"
"sync/atomic"
"testing"
Expand Down Expand Up @@ -553,3 +556,27 @@ func (suite *operatorTestSuite) TestOperatorCheckConcurrently() {
}
wg.Wait()
}

func TestOperatorCheckConcurrently(t *testing.T) {
re := require.New(t)
region := newTestRegion(1, 1, [2]uint64{1, 1}, [2]uint64{2, 2})
// addPeer1, transferLeader1, removePeer3
steps := []OpStep{
AddPeer{ToStore: 1, PeerID: 1},
TransferLeader{FromStore: 3, ToStore: 1},
RemovePeer{FromStore: 3},
}
op := NewTestOperator(1, &metapb.RegionEpoch{}, OpAdmin|OpLeader|OpRegion, steps...)
re.Equal(constant.Urgent, op.GetPriorityLevel())
checkSteps(re, op, steps)
op.Start()
var wg sync.WaitGroup
for i := 0; i < 10; i++ {
wg.Add(1)
go func() {
defer wg.Done()
re.Nil(op.Check(region))
}()
}
wg.Wait()
}

0 comments on commit 247158f

Please sign in to comment.