mcs: fix potential data race in scheduling server

Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot · Sep 22, 2024 · 3d132fc · 3d132fc
1 parent 67c89a2
commit 3d132fc
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/mcs/scheduling/server/server.go b/pkg/mcs/scheduling/server/server.go
@@ -199,6 +199,11 @@ func (s *Server) updateAPIServerMemberLoop() {
 				cc, err := s.GetDelegateClient(ctx, s.GetTLSConfig(), ep.ClientURLs[0])
 				if err != nil {
 					log.Info("failed to get delegate client", errs.ZapError(err))
+					continue
+				}
+				if !s.IsServing() {
+					// double check
+					break
 				}
 				if s.cluster.SwitchAPIServerLeader(pdpb.NewPDClient(cc)) {
 					if status.Leader != curLeader {