Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC for approving on extract file path #546

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

POC for approving on extract file path #546

wants to merge 3 commits into from

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jun 27, 2023 •
edited
Loading

No description provided.

@ti-chi-bot-dev ti-chi-bot-dev bot added do-not-merge/needs-linked-issue size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. lgtm and removed lgtm labels Jun 27, 2023
@wuhuizuo wuhuizuo closed this Jun 27, 2023
@wuhuizuo wuhuizuo reopened this Jun 27, 2023
@wuhuizuo

This comment was marked as outdated.

Sign in to view
1 similar comment
@ghost
Copy link

ghost commented Jun 27, 2023

/approve cancel

@ti-chi-bot-dev ti-chi-bot-dev bot removed the approved label Jun 27, 2023
@wuhuizuo wuhuizuo closed this Jun 28, 2023
@wuhuizuo wuhuizuo reopened this Jun 28, 2023
@wuhuizuo wuhuizuo closed this Jun 28, 2023
@wuhuizuo wuhuizuo reopened this Jun 28, 2023
@wuhuizuo wuhuizuo closed this Jun 28, 2023
@wuhuizuo wuhuizuo reopened this Jun 28, 2023
@wuhuizuo wuhuizuo closed this Jun 28, 2023
@wuhuizuo wuhuizuo reopened this Jun 28, 2023
@ghost

This comment was marked as outdated.

Sign in to view
@ti-chi-bot-dev ti-chi-bot-dev bot added the lgtm label Jun 28, 2023
@ghost ghost closed this Jun 28, 2023
@ghost ghost reopened this Jun 28, 2023
@ghost ghost closed this Jun 28, 2023
@ghost ghost reopened this Jun 28, 2023
@ghost ghost deleted a comment from ti-chi-bot-dev bot Jun 28, 2023
@ghost ghost closed this Jun 28, 2023
@ghost ghost reopened this Jun 28, 2023
@ghost ghost deleted a comment from ti-chi-bot-dev bot Jun 28, 2023
@ti-community-infra ti-community-infra deleted a comment Jun 29, 2023
@ti-community-infra ti-community-infra deleted a comment Jun 29, 2023
@ti-community-infra ti-community-infra deleted a comment Jun 29, 2023
@ti-community-infra ti-community-infra deleted a comment Jun 29, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

/approve cancel

@ti-chi-bot-dev ti-chi-bot-dev bot removed the approved label Jun 29, 2023
@wuhuizuo
Copy link
Contributor Author

/approve

@wuhuizuo
Copy link
Contributor Author

/approve cancel

@ti-chi-bot-dev
Copy link

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@wuhuizuo
Copy link
Contributor Author

/retest

@wuhuizuo
Copy link
Contributor Author

/test ?

@ti-chi-bot-dev
Copy link

@wuhuizuo: The following commands are available to trigger required jobs:

  • /test nest_prow_debug
  • /test pull-test-dev-validate-labels-yaml

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor Author

/test ?

@ti-chi-bot-dev
Copy link

@wuhuizuo: The following commands are available to trigger required jobs:

  • /test nest_prow_debug
  • /test pull-test-dev-validate-labels-yaml

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor Author

/approve

@wuhuizuo
Copy link
Contributor Author

/approve cancel

@ghost
Copy link

ghost commented Jul 17, 2023

/approve

3 similar comments
@zuo-bot-2
Copy link

/approve

@wuhuizuo
Copy link
Contributor Author

/approve

@wuhuizuo
Copy link
Contributor Author

/approve

@ti-chi-bot-dev
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind, wuhuizuo, zuo-bot-1, zuo-bot-2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wuhuizuo
wuhuizuo commented Jul 20, 2023
View reviewed changes
config/config.dat
@@ -0,0 +1 @@
just a file
Copy link
Contributor Author

@wuhuizuo wuhuizuo Jul 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be approved by approvers in <parent-folder>/OWNERS file since it not be controlled in /config/OWNERS file.

wuhuizuo
wuhuizuo commented Jul 20, 2023
View reviewed changes
config/config.toml.example
Comment on lines +5 to +8


hello
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It must be approved by approvers in /config/OWNERS file.

@ti-chi-bot
Copy link
Member

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or wuhuizuo.
/lifecycle stale

@ti-chi-bot
Copy link
Member

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Send feedback to sig-community-infra or Mini256.
/lifecycle rotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-linked-issue lgtm lifecycle/rotten size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wuhuizuo @purelind @zuo-bot-2 @ti-chi-bot