Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/profiler #55

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jterrats
Copy link

No description provided.

Copy link
Owner

@tiagonnascimento tiagonnascimento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jterrats - hey sir!

I just reviewed your work. Thank you!

However your unit tests are failing. Please try to run yarn test and probably you can see the error that I saw:

BuildsDeploy
    ✔ should execute the build with authentication
    ✔ should execute the build without authenticating again with test level defined
    ✔ should execute the build without authenticating again and without test level defined on buildfile

  verifies all commands run successfully 
    1) "before all" hook for "Fetch profile data passing all flags and project only is true"


  3 passing (14s)
  1 failing

  1) verifies all commands run successfully 
       "before all" hook for "Fetch profile data passing all flags and project only is true":
     Error: sf env:create:scratch --json -y 1 -w 10 -f config/project-scratch-def.json -d failed due to: {
  "code": 1,
  "context": "EnvCreateScratch",
  "commandName": "EnvCreateScratch",
  "message": "No default dev hub found. Use -v or --target-dev-hub to specify an environment.",
  "name": "NoDefaultDevHubError",
  "status": 1,
  "stack": "NoDefaultDevHubError: No default dev hub found. Use -v or --target-dev-hub to specify an environment.\n    at Messages.createError (/usr/local/lib/node_modules/@salesforce/cli/node_modules/@salesforce/core/lib/messages.js:393:16)\n    at getDefaultHub (/usr/local/lib/node_modules/@salesforce/cli/node_modules/@salesforce/sf-plugins-core/lib/flags/orgFlags.js:69:24)\n    at async getHubOrThrow (/usr/local/lib/node_modules/@salesforce/cli/node_modules/@salesforce/sf-plugins-core/lib/flags/orgFlags.js:74:42)",
  "exitCode": 1,
  "warnings": [
    "The \"env create scratch\" command has been deprecated. Use \"org create scratch\" instead."
  ]
}

      at setup (node_modules/@salesforce/cli-plugins-testkit/lib/testSession.js:249:27)
      at TestSession.createOrgs (node_modules/@salesforce/cli-plugins-testkit/lib/testSession.js:271:17)
      at TestSession.init (node_modules/@salesforce/cli-plugins-testkit/lib/testSession.js:167:20)
      at Function.create (node_modules/@salesforce/cli-plugins-testkit/node_modules/@salesforce/kit/lib/creatable.js:57:24)
      at Context.<anonymous> (test/commands/generate/profiler.test.ts:9:37)
      at processImmediate (node:internal/timers:471:21)

I think you will have to stub sf command, so a scratch org is not really created to test your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants