Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora 39 fixups #87

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Fedora 39 fixups #87

merged 3 commits into from
Dec 8, 2023

Conversation

osteffenrh
Copy link
Contributor

@osteffenrh osteffenrh commented Dec 6, 2023

Some fixups for the recently added Fedora 39 image:

Closes #84

@osteffenrh osteffenrh requested a review from a team December 6, 2023 14:37
@osteffenrh osteffenrh self-assigned this Dec 6, 2023
@Javagedes
Copy link

@osteffenrh Did you mean to remove all of the package installs? I'll refer to @cfernald, but I believe some of those are used for more than installing qemu - at a bare minimum git and python.

@makubacki
Copy link
Member

@osteffenrh Did you mean to remove all of the package installs? I'll refer to @cfernald, but I believe some of those are used for more than installing qemu - at a bare minimum git and python.

Those should be inherited from the build stage. There are some references used for the QEMU build that seem they could be dropped now though like QEMU_URL and QEMU_BRANCH.

Fedora 39 ships Qemu 8. We can use that instead of building it from
source.

Also add Qemu for RiscV.

Signed-off-by: Oliver Steffen <[email protected]>
Don't abort the entrypoint script if the user-id already exists.
This allows using the dev images as root or when using Podman,
which does some user mapping already.

See issue tianocore#76 and PR tianocore#77.

Signed-off-by: Oliver Steffen <[email protected]>
Add links and badges for the Fedora 39 images to the table.

Signed-off-by: Oliver Steffen <[email protected]>
@osteffenrh
Copy link
Contributor Author

@osteffenrh Did you mean to remove all of the package installs? I'll refer to @cfernald, but I believe some of those are used for more than installing qemu - at a bare minimum git and python.

Those should be inherited from the build stage.

Exactly. Those packages were only needed for building Qemu.

@Javagedes
Copy link

@osteffenrh Did you mean to remove all of the package installs? I'll refer to @cfernald, but I believe some of those are used for more than installing qemu - at a bare minimum git and python.

Those should be inherited from the build stage.

Exactly. Those packages were only needed for building Qemu.

Thanks for the clarification @makubacki , @osteffenrh :)

@osteffenrh osteffenrh merged commit 0bc7964 into tianocore:main Dec 8, 2023
1 check passed
mairudiF added a commit to mairudiF/containers that referenced this pull request Mar 2, 2024
* Add Fedora 39 image with gcc13 (tianocore#82)

Added Fedora 39 base image, providing GCC13 and Python 3.12.

Signed-off-by: Chao Li <[email protected]>

* Fedora 39 fixups (tianocore#87)

* Fedora 39: Use Qemu from package repo

Fedora 39 ships Qemu 8. We can use that instead of building it from
source.

Also add Qemu for RiscV.

Signed-off-by: Oliver Steffen <[email protected]>

* Allow using dev image as root

Don't abort the entrypoint script if the user-id already exists.
This allows using the dev images as root or when using Podman,
which does some user mapping already.

See issue tianocore#76 and PR tianocore#77.

Signed-off-by: Oliver Steffen <[email protected]>

* Readme: Add Fedora 39 image to table

Add links and badges for the Fedora 39 images to the table.

Signed-off-by: Oliver Steffen <[email protected]>

---------

Signed-off-by: Oliver Steffen <[email protected]>

* Fedora 39 Build Fixes (tianocore#88)

* Fedora39: Don't use fixed package versions

Specifying version numbers for the packages provided by the Linux
distribution is counterproductive. The available patchlevel versions of a
package can change within a Fedora release. This can breaks image builds
which requires additional manual work. Since the major versions stay
fixed, there should not be any compatibility issues between image
builds. Additionally, bug fixes are picked up automatically.

This patch removes the explicit version numbers from the packages and
installs the default versions instead.

Signed-off-by: Oliver Steffen <[email protected]>

* Fedora 39: Install python-setuptools via pip

Install python-setuptools via pip instead of taking it from the Fedora
repo. This avoids possible conflicts with `pip install --upgrade ...`

Signed-off-by: Oliver Steffen <[email protected]>

---------

Signed-off-by: Oliver Steffen <[email protected]>

---------

Signed-off-by: Chao Li <[email protected]>
Signed-off-by: Oliver Steffen <[email protected]>
Co-authored-by: Chao Li <[email protected]>
Co-authored-by: Oliver Steffen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixup Fedora 39
3 participants