edk2-libc: add github workflow to build app efi with GCC #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarsDoge
requested review from
mdkinney,
jpshivakavi and
bexcran
as code owners
|
This looks really good. Thanks for adding the new matrix of jobs. There may be ways to make this faster in the future by using a Fedora container image from TianoCore, but this build times right now are acceptable. |
|
I see files in this PR with Public Domain license, no license, and GPL license that are not allowed in the edk2 projects,. Please remove all files that do not use the allowed licenses. The libc implementation in this repo is based on the Berkley libc implementation. If possible, please use that source of content or remove files that are not needed. |
|
You are right, I'm sorry I overlooked that, I'll deal with the licensing issue next. |
REF: https://github.com/bminor/glibc https://github.com/loongson/glibc Signed-off-by: Dongyan Qian <[email protected]>
Signed-off-by: Dongyan Qian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.