Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow [tool] or [tools] section in Rust Env Checker #931

Merged

Conversation

makubacki
Copy link
Member

Currently, the plugin supports locating tools in a [tool] section. Other scripts and flows have been built around [tools]. This change finds tools from either section.

@makubacki makubacki requested a review from Javagedes February 6, 2025 14:13
@makubacki makubacki self-assigned this Feb 6, 2025
@makubacki makubacki changed the title Allow [tool] or [tools] section Rust Env Checker Allow [tool] or [tools] section in Rust Env Checker Feb 6, 2025
Currently, the plugin supports locating tools in a `[tool]` section.
Other scripts and flows have been built around `[tools]`. This change
finds tools from either section.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki force-pushed the rust_env_check_loosen_key_match branch from f306834 to df08b94 Compare February 6, 2025 14:14
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (bf643b0) to head (df08b94).
Report is 128 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
+ Coverage   78.75%   78.79%   +0.03%     
==========================================
  Files          49       41       -8     
  Lines        4909     5055     +146     
==========================================
+ Hits         3866     3983     +117     
- Misses       1043     1072      +29     
Files with missing lines Coverage Δ
edk2toolext/environment/rust.py 86.56% <100.00%> (ø)

... and 49 files with indirect coverage changes

@Javagedes Javagedes added the enhancement New feature or request label Feb 6, 2025
@Javagedes Javagedes added this to the v0.28.2 milestone Feb 6, 2025
@Javagedes Javagedes merged commit 9793738 into tianocore:master Feb 6, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants