Skip to content

Commit

Permalink
OvmfPkg: fix PcdFSBClock
Browse files Browse the repository at this point in the history 
kvm FSB clock is 1GHz, not 100 MHz.  Timings are off by factor 10.
Fix all affected build configurations.  Not changed: Microvm and
Cloudhw (they have already have the correct value), and Xen (has
no fixed frequency, the PCD is configured at runtime by platform
initialization code).

Fixes: c37cbc0 ("OvmfPkg: Switch timer in build time for OvmfPkg")
Reported-by: Laszlo Ersek <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
Reviewed-by: Jiewen Yao <[email protected]>
  • Loading branch information
@kraxel @mergify
kraxel authored and mergify[bot] committed May 25, 2022
1 parent 9c733f0 commit 07c0c2e
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion OvmfPkg/AmdSev/AmdSevX64.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@

!include OvmfPkg/OvmfTpmPcds.dsc.inc

gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000
gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000

[PcdsDynamicHii]
!include OvmfPkg/OvmfTpmPcdsHii.dsc.inc
Expand Down
2 changes: 1 addition & 1 deletion OvmfPkg/IntelTdx/IntelTdxX64.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@
# Set ConfidentialComputing defaults
gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0

gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000
gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000

################################################################################
#
Expand Down
2 changes: 1 addition & 1 deletion OvmfPkg/OvmfPkgIa32.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@
gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0

!if $(CSM_ENABLE) == FALSE
gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000
gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000
!endif

[PcdsDynamicHii]
Expand Down
2 changes: 1 addition & 1 deletion OvmfPkg/OvmfPkgIa32X64.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@
gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0

!if $(CSM_ENABLE) == FALSE
gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000
gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000
!endif

[PcdsDynamicDefault.X64]
Expand Down
2 changes: 1 addition & 1 deletion OvmfPkg/OvmfPkgX64.dsc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@
gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0

!if $(CSM_ENABLE) == FALSE
gEfiMdePkgTokenSpaceGuid.PcdFSBClock|100000000
gEfiMdePkgTokenSpaceGuid.PcdFSBClock|1000000000
!endif

[PcdsDynamicHii]
Expand Down

0 comments on commit 07c0c2e

Please sign in to comment.