Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseTools: Add ImageCapsuleSupport field to header #6473

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

BaseTools: Add ImageCapsuleSupport field to header #6473

wants to merge 1 commit into from

Conversation

bexcran
Copy link
Contributor

@bexcran bexcran commented Nov 27, 2024

Description

I noticed when adding support for authenticated capsule updates that the code in GenFds was missing the last field from EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER. I don't know if it makes any difference, but we should probably be including it.

Note Obviously this is a very basic implementation which isn't complete and probably shouldn't be merged.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Generated capsules and verified they installed correctly via FMP.

Integration Instructions

N/A

@bexcran
BaseTools: Add ImageCapsuleSupport field to header
825dcc5 
The EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER structure has an
additional field 'ImageCapsuleSupport' which is ommitted when
generating capsules via GenFds.

Add basic support for it by hardcoding it to 1, indicating that the
capsule supports authentication.

Signed-off-by: Rebecca Cran <[email protected]>
@bexcran bexcran marked this pull request as draft November 27, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobCF BobCF Awaiting requested review from BobCF

@lgao4 lgao4 Awaiting requested review from lgao4

@YuweiChen1110 YuweiChen1110 Awaiting requested review from YuweiChen1110

@mdkinney mdkinney Awaiting requested review from mdkinney

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bexcran