Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PullRequests.github-issues: Add PR notebook #6493

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

makubacki
Copy link
Member

Description

Adds a VS Code GitHub issue notebook that can be used with the VS Code GitHub Issue Notebook Extension to view PR queries on Tianocore repositories.

VS Code extension:
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-github-issue-notebooks

This is intended to provide a single real-time dashboard that reflects PR status from all Tianocore repositories so users can track their PRs and quickly find PRs that need their attention.

To use this, install the VS Code extension and open the file. This can be done in a Web browser at vscode.dev or locally in VS Code.


This was shown in the Tianocore Tools & CI meeting as a view to help bring visibility to PRs.

Example of Notebook

image
  • Breaking change?
  • Impacts security?
  • Includes tests?

How This Was Tested

  • Used the notebook in VS Code to view PRs on Tianocore repositories

Integration Instructions

  • N/A

@makubacki makubacki force-pushed the add_issue_notebook branch 3 times, most recently from 8204e04 to ea3b482 Compare December 3, 2024 15:32
@leiflindholm
Copy link
Member

Does this file need to live in the top-level directory?

@makubacki
Copy link
Member Author

Does this file need to live in the top-level directory?

It does not. It can be moved elsewhere. We've placed a few into a "Notebooks" directory with a readme - https://github.com/microsoft/mu_devops/tree/main/Notebooks.

@leiflindholm
Copy link
Member

It does not. It can be moved elsewhere. We've placed a few into a "Notebooks" directory with a readme - https://github.com/microsoft/mu_devops/tree/main/Notebooks.

This sort of came up in #6455 today as well. We don't have a generic directory for "useful stuff", and as a result we have some of that spread out across the tree. Things like debugger scripts. @hughsie's PR linked to a document talking about how a contrib directory might be a reasonable location for that type of file.

This, like that, PR shouldn't have to be the driving force for that ... but maybe it's just time to figure something out?

@hughsie
Copy link

hughsie commented Dec 5, 2024

@hughsie votes ./contrib :)

@makubacki
Copy link
Member Author

I moved it to ./contrib.

@makubacki
Copy link
Member Author

@leiflindholm & @mdkinney, can you please revisit this when you get a chance?

@leiflindholm
Copy link
Member

I'm good with this, but also happy to bikeshed :)

@mdkinney
Copy link
Member

This adds a new dir to the root. Do you want to update Maintainers.txt for maintainers/reviewers?

Adds a VS Code GitHub issue notebook that can be used with the VS
Code GitHub Issue Notebook Extension to view PR queries on
Tianocore repositories.

VS Code extension:
https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-github-issue-notebooks

This is intended to provide a single real-time dashboard that
reflects PR status from all Tianocore repositories so users can
track their PRs and quickly find PRs that need their attention.

To use this, install the VS Code extension and open the file.
This can be done in a Web browser at vscode.dev or locally in
VS Code.

Signed-off-by: Michael Kubacki <[email protected]>
Adds Michael Kubacki as a maintainer of this newly added file.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki
Copy link
Member Author

This adds a new dir to the root. Do you want to update Maintainers.txt for maintainers/reviewers?

I added myself as a maintainer of the file. Given the diverse nature of file content that can be placed in the /contrib directory, I cannot assume directory ownership. I imagine this would be a common trend for files in there.

@mdkinney mdkinney added the push Auto push patch series in PR if all checks pass label Dec 10, 2024
@mergify mergify bot merged commit 4c7c902 into tianocore:master Dec 10, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants