-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17 align with gbv dfg2024 #33
17 align with gbv dfg2024 #33
Conversation
… into 17-align-with-httpsurigbvdeterminologydfg
OK so the owl:sameAs statements mapping each term to GBV dfg2024 are on script and TTL. @nichtich & @SArndt-TIB do you want to have a look at the dfgo.ttl diff and see if you agree with the mapping. I used the full URI as I was not sure what prefix to use. If you have any suggestions let me know. Otherwise let's go with the URI. Anything else we should mention about this mapping? |
@andrecastro0o Looks good to me. We have to be aware, that owl:sameAs is used to express a relation between individuals - that will cause a punning of our classes. Protege, for instance, will list all the classes as individuls, too. The same would happen with something like skos:exactMatch. We could prevent this by using a less strict property like rdfs:seeAlso. I am not sure, what else to say about the mapping, right now. |
@SArndt-TIB thank you for the feedback. I tried the same with Looking at their definitions in skos-reference/#mapping I would say that
I don't think rdfs:seeAlso expresses a relation of similarity between these 2 sets of terms.
|
Also I will add an editor note to the metadata:
Feel free to add any suggestions |
@andrecastro0o Thanks!
If you do not import skos, skos:exactMatch is likely interpreted as an annotation property (that's also causing the profile error). skos:exactMatch is an object property - when you import skos, the same as with owl:sameAs should happen. I agree that rdfs:seeAlso is too weak for a mapping. Using skos:closeMatch makes sense due to the reasons you name. |
thanks @SArndt-TIB I wasn't aware of it. a bit rusty on this ontology design details. How to best deal with this 💩 ? I am happy to ditch the DL-profile validation test. Or just use a seeAlso, but darn, this stuff is hard!
|
@andrecastro0o Yeah, I see. Well, I added some quick fix, that avoids the "Rattenschwanz" of the import. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions where we do not need to drop the profile check.
super @SArndt-TIB ! thank you. I will merge to main :) |
closes #17