Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patchday #1264

Merged
merged 29 commits into from
Jan 29, 2025
Merged

patchday #1264

merged 29 commits into from
Jan 29, 2025

Conversation

felixroos
Copy link
Collaborator

@felixroos felixroos commented Jan 26, 2025

this PR updates all npm package versions.

major version updates:

  • update vite to v6
  • update vitest to v3
  • update fraction js to v5
  • update tauri to v2
  • update peggy to v4
  • update react to v19
  • update worker-timers to v8
  • remove vite-pwa typings as they created problems
  • update astro to v5

things i needed to migrate:

  • migrate eslint config
  • update some github action versions
  • remove @uiw/* packages from codemirror + rewrite the themes
show all version changes

root folder packages:

┌────────────────────────────────┬─────────┬────────┐
│ Package                        │ Current │ Latest │
├────────────────────────────────┼─────────┼────────┤
│ jsdoc (dev)                    │ 4.0.3   │ 4.0.4  │
├────────────────────────────────┼─────────┼────────┤
│ lerna (dev)                    │ 8.1.8   │ 8.1.9  │
├────────────────────────────────┼─────────┼────────┤
│ acorn (dev)                    │ 8.13.0  │ 8.14.0 │
├────────────────────────────────┼─────────┼────────┤
│ prettier (dev)                 │ 3.3.3   │ 3.4.2  │
├────────────────────────────────┼─────────┼────────┤
│ rollup-plugin-visualizer (dev) │ 5.12.0  │ 5.14.0 │
├────────────────────────────────┼─────────┼────────┤
│ @tauri-apps/cli (dev)          │ 1.6.3   │ 2.2.5  │
├────────────────────────────────┼─────────┼────────┤
│ @vitest/ui (dev)               │ 2.1.3   │ 3.0.4  │
├────────────────────────────────┼─────────┼────────┤
│ dependency-tree (dev)          │ 10.0.9  │ 11.0.1 │
├────────────────────────────────┼─────────┼────────┤
│ eslint (dev)                   │ 8.57.1  │ 9.18.0 │
├────────────────────────────────┼─────────┼────────┤
│ jsdoc-to-markdown (dev)        │ 8.0.3   │ 9.1.1  │
└────────────────────────────────┴─────────┴────────┘
  • @tauri-apps/cli required some migration
  • eslint required some migration
  • removed jsdoc-to-markdown (unused)

@strudel/codemirror:

┌────────────────────────────────┬─────────┬────────┐
│ Package                        │ Current │ Latest │
├────────────────────────────────┼─────────┼────────┤
│ jsdoc (dev)                    │ 4.0.3   │ 4.0.4  │
├────────────────────────────────┼─────────┼────────┤
│ lerna (dev)                    │ 8.1.8   │ 8.1.9  │
├────────────────────────────────┼─────────┼────────┤
│ acorn (dev)                    │ 8.13.0  │ 8.14.0 │
├────────────────────────────────┼─────────┼────────┤
│ prettier (dev)                 │ 3.3.3   │ 3.4.2  │
├────────────────────────────────┼─────────┼────────┤
│ rollup-plugin-visualizer (dev) │ 5.12.0  │ 5.14.0 │
├────────────────────────────────┼─────────┼────────┤
│ @tauri-apps/cli (dev)          │ 1.6.3   │ 2.2.5  │
├────────────────────────────────┼─────────┼────────┤
│ dependency-tree (dev)          │ 10.0.9  │ 11.0.1 │
├────────────────────────────────┼─────────┼────────┤
│ eslint (dev)                   │ 8.57.1  │ 9.18.0 │
├────────────────────────────────┼─────────┼────────┤
│ jsdoc-to-markdown (dev)        │ 8.0.3   │ 9.1.1  │
└────────────────────────────────┴─────────┴────────┘

@strudel/core:

┌──────────────┬───────────────────────┬────────┐
│ Package      │ Current               │ Latest │
├──────────────┼───────────────────────┼────────┤
│ fraction.js  │ 5.2.1 (wanted 4.3.7)  │ 5.2.1  │
└──────────────┴───────────────────────┴────────┘

@strudel/desktopbridge

┌─────────────────┬─────────┬────────┐
│ Package         │ Current │ Latest │
├─────────────────┼─────────┼────────┤
│ @tauri-apps/api │ 1.6.0   │ 2.2.0  │
└─────────────────┴─────────┴────────┘

@strudel/hs2js

┌───────────────────────────┬───────────────────────┬────────┐
│ Package                   │ Current               │ Latest │
├───────────────────────────┼───────────────────────┼────────┤
│ tree-sitter-haskell (dev) │ 0.21.0                │ 0.23.1 │
├───────────────────────────┼───────────────────────┼────────┤
│ web-tree-sitter           │ 0.20.8                │ 0.24.7 │
└───────────────────────────┴───────────────────────┴────────┘

@strudel/midi

┌────────────┬────────────────────────┬────────┐
│ Package    │ Current                │ Latest │
├────────────┼────────────────────────┼────────┤
│ webmidi    │ 3.1.12 (wanted 3.1.11) │ 3.1.12 │
└────────────┴────────────────────────┴────────┘

@strudel/mini

┌──────────────┬───────────────────────┬────────┐
│ Package      │ Current               │ Latest │
├──────────────┼───────────────────────┼────────┤
│ peggy (dev)  │ 4.2.0 (wanted 3.0.2)  │ 4.2.0  │
└──────────────┴───────────────────────┴────────┘

@strudel/repl

┌────────────────────────────────┬────────────────────────┬────────┐
│ Package                        │ Current                │ Latest │
├────────────────────────────────┼────────────────────────┼────────┤
│ rollup-plugin-visualizer (dev) │ 5.14.0 (wanted 5.12.0) │ 5.14.0 │
├────────────────────────────────┼────────────────────────┼────────┤
│ @rollup/plugin-replace (dev)   │ 5.0.7                  │ 6.0.2  │
└────────────────────────────────┴────────────────────────┴────────┘

@strudel/soundfonts

┌────────────┬───────────────────────┬────────┐
│ Package    │ Current               │ Latest │
├────────────┼───────────────────────┼────────┤
│ soundfont2 │ 0.4.0                 │ 0.5.0  │
└────────────┴───────────────────────┴────────┘

superdough

┌────────────┬───────────────────────┬────────┐
│ Package    │ Current               │ Latest │
├────────────┼───────────────────────┼────────┤
│ nanostores │ 0.9.5                 │ 0.11.3 │
└────────────┴───────────────────────┴────────┘

@strudel/tonal

┌──────────────┬────────────────────────┬────────┐
│ Package      │ Current                │ Latest │
├──────────────┼────────────────────────┼────────┤
│ webmidi      │ 3.1.12 (wanted 3.1.11) │ 3.1.12 │
└──────────────┴────────────────────────┴────────┘

@strudel/transpiler

┌──────────────┬────────────────────────┬────────┐
│ Package      │ Current                │ Latest │
├──────────────┼────────────────────────┼────────┤
│ acorn        │ 8.14.0 (wanted 8.13.0) │ 8.14.0 │
└──────────────┴────────────────────────┴────────┘

@strudel/web

┌──────────────────────────────┬───────────────────────┬────────┐
│ Package                      │ Current               │ Latest │
├──────────────────────────────┼───────────────────────┼────────┤
│ @rollup/plugin-replace (dev) │ 5.0.7                 │ 6.0.2  │
└──────────────────────────────┴───────────────────────┴────────┘

website/

┌──────────────────────────────────────┬──────────┬──────────┐
│ Package                              │ Current  │ Latest   │
├──────────────────────────────────────┼──────────┼──────────┤
│ @algolia/client-search               │ 4.24.0   │ 5.20.0   │
├──────────────────────────────────────┼──────────┼──────────┤
│ @astrojs/mdx                         │ 2.3.1    │ 4.0.7    │
├──────────────────────────────────────┼──────────┼──────────┤
│ @astrojs/react                       │ 3.6.3    │ 4.1.6    │
├──────────────────────────────────────┼──────────┼──────────┤
│ @headlessui/react                    │ 1.7.19   │ 2.2.0    │
├──────────────────────────────────────┼──────────┼──────────┤
│ @tauri-apps/api                      │ 1.6.0    │ 2.2.0    │
├──────────────────────────────────────┼──────────┼──────────┤
│ @types/node                          │ 20.17.16 │ 22.10.10 │
├──────────────────────────────────────┼──────────┼──────────┤
│ @types/react                         │ 18.3.18  │ 19.0.8   │
├──────────────────────────────────────┼──────────┼──────────┤
│ @types/react-dom                     │ 18.3.5   │ 19.0.3   │
├──────────────────────────────────────┼──────────┼──────────┤
│ astro                                │ 4.16.18  │ 5.1.9    │
├──────────────────────────────────────┼──────────┼──────────┤
│ date-fns                             │ 3.6.0    │ 4.1.0    │
├──────────────────────────────────────┼──────────┼──────────┤
│ react                                │ 18.3.1   │ 19.0.0   │
├──────────────────────────────────────┼──────────┼──────────┤
│ react-dom                            │ 18.3.1   │ 19.0.0   │
├──────────────────────────────────────┼──────────┼──────────┤
│ tailwindcss                          │ 3.4.17   │ 4.0.0    │
├──────────────────────────────────────┼──────────┼──────────┤
│ worker-timers                        │ 7.1.8    │ 8.0.13   │
├──────────────────────────────────────┼──────────┼──────────┤
│ @astro-community/astro-embed-youtube │ 0.4.5    │ 0.5.6    │
├──────────────────────────────────────┼──────────┼──────────┤
│ @nanostores/persistent               │ 0.9.1    │ 0.10.2   │
├──────────────────────────────────────┼──────────┼──────────┤
│ @nanostores/react                    │ 0.7.3    │ 0.8.4    │
├──────────────────────────────────────┼──────────┼──────────┤
│ @vite-pwa/astro (dev)                │ 0.2.0    │ 0.5.0    │
├──────────────────────────────────────┼──────────┼──────────┤
│ hs2js                                │ 0.0.8    │ 0.1.0    │
├──────────────────────────────────────┼──────────┼──────────┤
│ nanostores                           │ 0.9.5    │ 0.11.3   │
├──────────────────────────────────────┼──────────┼──────────┤
│ vite-plugin-pwa (dev)                │ 0.17.5   │ 0.21.1   │
└──────────────────────────────────────┴──────────┴──────────┘

@felixroos felixroos mentioned this pull request Jan 27, 2025
@felixroos felixroos requested a review from daslyfe January 28, 2025 19:10
@felixroos felixroos marked this pull request as ready for review January 28, 2025 19:11
@felixroos
Copy link
Collaborator Author

i've updated all packages, including tauri, @daslyfe would you want to test if the desktop version still works? are you generally interested to keep it alive? i'm not sure how many people use it / if people use it at all

@daslyfe
Copy link
Collaborator

daslyfe commented Jan 29, 2025

i've updated all packages, including tauri, @daslyfe would you want to test if the desktop version still works? are you generally interested to keep it alive? i'm not sure how many people use it / if people use it at all

Im not sure either TBH. The limiting thing with the desktop app is webkit. It looks like tauri might be getting webview 2 sometime next year: tauri-apps/wry#1064 . TBH though I think the desktop app should be a seperated and use strudel as a package so im fine with killing it even if it makes me feel a little sad

@felixroos
Copy link
Collaborator Author

i've updated all packages, including tauri, @daslyfe would you want to test if the desktop version still works? are you generally interested to keep it alive? i'm not sure how many people use it / if people use it at all

Im not sure either TBH. The limiting thing with the desktop app is webkit. It looks like tauri might be getting webview 2 sometime next year: tauri-apps/wry#1064 . TBH though I think the desktop app should be a seperated and use strudel as a package so im fine with killing it even if it makes me feel a little sad

yeah webkit is a show stopper for webaudio. not sure if shipping chromium is the right way.. a native sound engine would be the optimal way to go imo, then tauri would suddenly make a lot of sense.
an alternative approach would be to ship a binary that serves the static html, but instead of opening a window through the OS, it could open the default browser. i've tried that before in another projects and it's super easy + lightweight.
but i'll keep it as is in this PR, then we can remove it in a separate PR if we want. my main motivation to remove it is that it's less maintenence required / it feels like a waste of time to maintain it when it's not in use.
I'd still keep the rust integrations you've written, as they will come in handy when we have a better plan

@felixroos felixroos merged commit fac698e into main Jan 29, 2025
2 checks passed
@felixroos felixroos deleted the housekeeping branch January 29, 2025 14:22
@daslyfe
Copy link
Collaborator

daslyfe commented Jan 29, 2025

i've updated all packages, including tauri, @daslyfe would you want to test if the desktop version still works? are you generally interested to keep it alive? i'm not sure how many people use it / if people use it at all

Im not sure either TBH. The limiting thing with the desktop app is webkit. It looks like tauri might be getting webview 2 sometime next year: tauri-apps/wry#1064 . TBH though I think the desktop app should be a seperated and use strudel as a package so im fine with killing it even if it makes me feel a little sad

yeah webkit is a show stopper for webaudio. not sure if shipping chromium is the right way.. a native sound engine would be the optimal way to go imo, then tauri would suddenly make a lot of sense. an alternative approach would be to ship a binary that serves the static html, but instead of opening a window through the OS, it could open the default browser. i've tried that before in another projects and it's super easy + lightweight. but i'll keep it as is in this PR, then we can remove it in a separate PR if we want. my main motivation to remove it is that it's less maintenence required / it feels like a waste of time to maintain it when it's not in use. I'd still keep the rust integrations you've written, as they will come in handy when we have a better plan

I agree then, probably best to remove it. If we can pack it into a small binary that seems more elegant and appropriate for where this project is at right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants